#3129 - Domain Renewal Form (Expiring Soon and Expired) - [AD] #3273

therealslimhsiehdy · 2024-12-27T01:11:39Z

Ticket

Resolves #3129

Changes

Domain Renewal Form Figma
Domain Renewal Detail Page Expired
For expiring soon and expired domains, we now have a renewal form for domain managers to fill out and/or confirm through
Documentation on how to add in an expiring soon domain to play with on sandbox

Context for reviewers

For domains that are expired and expiring soon, we now have a Renewal form that domain managers can fill out to renew their domains by 1 year.

Setup

EXPIRING DOMAINS in Org Model Mode under the Hotel California:

cooscountyor.gov
detroit.gov
elkrivermn.gov
gloucesterva.gov
headoftheharborny.gov
healthdata.gov
hvlnc.gov
jeffersonknoxohio.gov
montgomerycountyhealthky.gov
pembinewi.gov
pikecoga.gov
richlandcountywi.gov
stantonca.gov
texasjcmh.gov
texasstateparks.gov
vanburencountytn.gov
ipageaz.gov

EXPIRING DOMAINS in Non Org Mode:
NOTE:
You will need to go into domain, search for domain -> manage domain -> add self as domain manager
If your email is not working, add yourself as an allowed email list on my sandbox

arcoidaho.gov
hendersoncountytn.gov
hinsdalema.gov
linndalevillage-oh.gov
mapletonmn.gov
mountvernonin.gov
neenahwi.gov
newmadridcountymo.gov
nls.gov
pointpleasantbeachnj.gov
swcleanair.gov
waitehilloh.gov
hardwick-ma.gov

EXPIRED DOMAINS in Org Model Mode under the Hotel California portfolio:

erieco.gov
hendersoncountyil.gov
humboldt-wi.gov
lafayettecountymo.gov
laquintaca.gov
legmt.gov
ngla.gov
shreveportlawater.gov
somersettx.gov
stalbanswv.gov
swaincountync.gov
texicopolicenm.gov
build.gov
kingstonsprings-tn.gov
maizeks.gov
pitu.gov
randallso.gov
townofnilesny.gov
woodhavenmi.gov

EXPIRED DOMAINS in In Non Org Mode:
NOTE:
You will need to go into domain, search for domain -> manage domain -> add self as domain manager
If your email is not working, add yourself as an allowed email list on my sandbox

bearcreektownshipmi.gov
brantleycounty-ga.gov
chesapeakewv.gov
fairmontnc.gov
fultoncountyny.gov
lptami.gov
montgomerycountync.gov
opensource.gov
peoriaparks-il.gov
riverwoods.gov
santaclarita.gov
scit-nsn.gov
townofdunbarwi.gov
warnernh.gov
waynecountyil.gov
flpd6.gov

In theory, I should've added enough domains that are expiring soon to the RH sandbox -- if you do not see any, please let either Aditi and/or Rebecca know and we can add some in for you (sorry for the inconvenience!).
Go to /admin and turn the domain renewal waffle flag on (no org model yet)
If you are not a domain manager of any of these domains, add yourself as a domain manager (via /admin -> Domains -> Manage Domains -> Add yourself)
You should now see the renewal form in the sidebar. You can also access the form on the Domain Overview page via the link Renew to maintain access under the status.
When you arrive at the Domain Renewal Form, you can test out editing your contact, security, and domain managers. Then, submit it to renew the domain.
Now go to /admin and turn on the organization_feature flag and run through the same scenarios as above. (The ones I have added should be in the Agency Of The Litterbox Association portfolio, and you will probably need to add yourself as a domain manager to play around with it)

Note: The only difference between the org model and non org model view is that the org model view has breadcrumbs on top, but the non org model view does. The form should otherwise be the same.

Code Review Verification Steps

As the original developer, I have

Satisfied acceptance criteria and met development standards

Met the acceptance criteria, or will meet them in a subsequent PR
Created/modified automated tests
Update documentation in READMEs and/or onboarding guide

Ensured code standards are met (Original Developer)

If any updated dependencies on Pipfile, also update dependencies in requirements.txt.
Interactions with external systems are wrapped in try/except
Error handling exists for unusual or missing values

Validated user-facing changes (if applicable)

Tag @dotgov-designers in this PR's Reviewers for design review. If code is not user-facing, delete design reviewer checklist
Verify new pages have been added to .pa11yci file so that they will be tested with our automated accessibility testing
Checked keyboard navigability
Tested general usability, landmarks, page header structure, and links with a screen reader (such as Voiceover or ANDI)

As a code reviewer, I have

Reviewed, tested, and left feedback about the changes

Pulled this branch locally and tested it
Verified code meets all checks above. Address any checks that are not satisfied
Reviewed this code and left comments. Indicate if comments must be addressed before code is merged
Checked that all code is adequately covered by tests
Verify migrations are valid and do not conflict with existing migrations

Validated user-facing changes as a developer

Note: Multiple code reviewers can share the checklists above, a second reviewer should not make a duplicate checklist. All checks should be checked before approving, even those labeled N/A.

New pages have been added to .pa11yci file so that they will be tested with our automated accessibility testing
Checked keyboard navigability
Meets all designs and user flows provided by design/product
Tested general usability, landmarks, page header structure, and links with a screen reader (such as Voiceover or ANDI)
(Rarely needed) Tested as both an analyst and applicant user

As a designer reviewer, I have

Verified that the changes match the design intention

Checked that the design translated visually
Checked behavior. Comment any found issues or broken flows.
Checked different states (empty, one, some, error)
Checked for landmarks, page heading structure, and links

Validated user-facing changes as a designer

Checked keyboard navigability
Tested general usability, landmarks, page header structure, and links with a screen reader (such as Voiceover or ANDI)
Tested with multiple browsers (check off which ones were used)
- Chrome
- Microsoft Edge
- FireFox
- Safari
(Rarely needed) Tested as both an analyst and applicant user

References

Code review best practices

Screenshots

github-actions · 2024-12-27T01:16:08Z

🥳 Successfully deployed to developer sandbox rh.

github-actions · 2024-12-27T01:19:48Z

🥳 Successfully deployed to developer sandbox rh.

github-actions · 2024-12-30T17:10:23Z

🥳 Successfully deployed to developer sandbox rh.

github-actions · 2024-12-30T17:50:35Z

🥳 Successfully deployed to developer sandbox rh.

github-actions · 2024-12-31T18:21:11Z

🥳 Successfully deployed to developer sandbox rh.

github-actions · 2024-12-31T18:59:58Z

🥳 Successfully deployed to developer sandbox rh.

github-actions · 2025-01-03T15:48:22Z

🥳 Successfully deployed to developer sandbox rh.

github-actions · 2025-01-03T18:58:20Z

🥳 Successfully deployed to developer sandbox rh.

github-actions · 2025-01-03T19:33:11Z

🥳 Successfully deployed to developer sandbox rh.

github-actions · 2025-01-04T22:22:25Z

🥳 Successfully deployed to developer sandbox rh.

github-actions · 2025-01-04T22:53:08Z

🥳 Successfully deployed to developer sandbox rh.

github-actions · 2025-01-04T23:00:06Z

🥳 Successfully deployed to developer sandbox rh.

github-actions · 2025-01-10T18:01:21Z

🥳 Successfully deployed to developer sandbox rh.

github-actions · 2025-01-10T19:07:17Z

🥳 Successfully deployed to developer sandbox rh.

github-actions · 2025-01-10T20:13:45Z

🥳 Successfully deployed to developer sandbox rh.

github-actions · 2025-01-10T20:39:45Z

🥳 Successfully deployed to developer sandbox rh.

github-actions · 2025-01-10T20:41:49Z

🥳 Successfully deployed to developer sandbox rh.

github-actions · 2025-01-10T20:45:37Z

🥳 Successfully deployed to developer sandbox rh.

Has been addressed per Aditi's comments and commits

…gov/manage.get.gov into rh/3129-domain-renewal-form

github-actions · 2025-01-10T21:09:36Z

🥳 Successfully deployed to developer sandbox rh.

kristinacyin

There's a couple of things that need to be relegated to post-POD work, but great job! Can't believe we've accomplished so much in such a short amount of time.

dave-kennedy-ecs · 2025-01-10T22:06:19Z

src/registrar/views/domain.py

+    def can_access_domain_via_portfolio(self, pk):
+        """Most views should not allow permission to portfolio users.
+        If particular views allow permissions, they will need to override
+        this function."""
+        portfolio = self.request.session.get("portfolio")
+        if self.request.user.has_any_domains_portfolio_permission(portfolio):
+            if Domain.objects.filter(id=pk).exists():
+                domain = Domain.objects.get(id=pk)
+                if domain.domain_info.portfolio == portfolio:
+                    return True
+        return False


One more. Looks like this one should also be deleted.

dave-kennedy-ecs

Approve, pending removal of the additional noted method in the view.

Thank you for all of the test cases in the PR notes. This was especially helpful for testing, and Rebecca was really helpful jumping on a call to walk through the PR

… rh/3129-domain-renewal-form

github-actions · 2025-01-13T17:03:48Z

🥳 Successfully deployed to developer sandbox rh.

github-actions · 2025-01-13T17:13:30Z

🥳 Successfully deployed to developer sandbox rh.

… rh/3129-domain-renewal-form

github-actions · 2025-01-13T18:42:09Z

🥳 Successfully deployed to developer sandbox rh.

Renewal form

d84a789

therealslimhsiehdy mentioned this pull request Dec 27, 2024

[DRAFT] #3137 - Tech Discovery On Renewal Form - [RH] #3248

Closed

32 tasks

Fix linter

b5658a3

asaki222 and others added 2 commits December 30, 2024 11:07

added back domain renewal form

8b9eb93

Add in the domain renewal template oops

19e5700

asaki222 added 2 commits December 30, 2024 12:44

added renew method

e23d81f

added renewal form

8d8616e

therealslimhsiehdy added 2 commits December 31, 2024 10:13

Update print statements and exp timing

a128086

Fix conflict and merge

c4b6037

put back the fixtures command

c145ecb

added tests

e5f9696

Add in tests for making edit is clickable and goes to right route

4feb29b

Update text to click on link

3f3ba22

Unit test for submit and recieving error message

dca70f4

Fix padding on form and addin subtext for security email

bad8a8c

Removing print statements

a3c5004

Update test and add in documentation

3dc445d

therealslimhsiehdy changed the title ~~[DRAFT] #3129 - Tech Discovery On Renewal Form - [RH]~~ #3129 - Domain Renewal Form - [RH] Jan 6, 2025

Fix test capitalization

25ba5b2

Fix checkbox issue

19114c7

Add in error above ack checkbox and allow edit even after refresh

53f48ba

asaki222 added 2 commits January 10, 2025 15:35

fixed sidebar issue

737851d

updated with comment

b47ab07

Fix wideness of the lines

dac673a

therealslimhsiehdy requested a review from dave-kennedy-ecs January 10, 2025 20:49

kristinacyin self-requested a review January 10, 2025 20:50

asaki222 added 2 commits January 10, 2025 16:04

added exec info true

9241790

Merge branch 'rh/3129-domain-renewal-form' of https://github.com/cisa…

6b1185e

…gov/manage.get.gov into rh/3129-domain-renewal-form

kristinacyin approved these changes Jan 10, 2025

View reviewed changes

dave-kennedy-ecs reviewed Jan 10, 2025

View reviewed changes

dave-kennedy-ecs approved these changes Jan 10, 2025

View reviewed changes

therealslimhsiehdy added 2 commits January 13, 2025 08:58

Remove duplicated function

797561d

Merge branch 'main' of https://github.com/cisagov/manage.get.gov into…

c3161ea

… rh/3129-domain-renewal-form

Merge branch 'main' of https://github.com/cisagov/manage.get.gov into…

ef43851

… rh/3129-domain-renewal-form

therealslimhsiehdy assigned dave-kennedy-ecs Jan 13, 2025

asaki222 merged commit a0a53ea into main Jan 13, 2025
10 checks passed

asaki222 deleted the rh/3129-domain-renewal-form branch January 13, 2025 19:09

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

#3129 - Domain Renewal Form (Expiring Soon and Expired) - [AD] #3273

#3129 - Domain Renewal Form (Expiring Soon and Expired) - [AD] #3273

therealslimhsiehdy commented Dec 27, 2024 •

edited

Loading

github-actions bot commented Dec 27, 2024

github-actions bot commented Dec 27, 2024

github-actions bot commented Dec 30, 2024

github-actions bot commented Dec 30, 2024

github-actions bot commented Dec 31, 2024

github-actions bot commented Dec 31, 2024

github-actions bot commented Jan 3, 2025

github-actions bot commented Jan 3, 2025

github-actions bot commented Jan 3, 2025

github-actions bot commented Jan 4, 2025

github-actions bot commented Jan 4, 2025

github-actions bot commented Jan 4, 2025

github-actions bot commented Jan 10, 2025

github-actions bot commented Jan 10, 2025

github-actions bot commented Jan 10, 2025

github-actions bot commented Jan 10, 2025

github-actions bot commented Jan 10, 2025

github-actions bot commented Jan 10, 2025

github-actions bot commented Jan 10, 2025

kristinacyin left a comment

dave-kennedy-ecs Jan 10, 2025

dave-kennedy-ecs left a comment

github-actions bot commented Jan 13, 2025

github-actions bot commented Jan 13, 2025

github-actions bot commented Jan 13, 2025

#3129 - Domain Renewal Form (Expiring Soon and Expired) - [AD] #3273

#3129 - Domain Renewal Form (Expiring Soon and Expired) - [AD] #3273

Conversation

therealslimhsiehdy commented Dec 27, 2024 • edited Loading

Ticket

Changes

Context for reviewers

Setup

Code Review Verification Steps

As the original developer, I have

Satisfied acceptance criteria and met development standards

Ensured code standards are met (Original Developer)

Validated user-facing changes (if applicable)

As a code reviewer, I have

Reviewed, tested, and left feedback about the changes

Validated user-facing changes as a developer

As a designer reviewer, I have

Verified that the changes match the design intention

Validated user-facing changes as a designer

References

Screenshots

github-actions bot commented Dec 27, 2024

github-actions bot commented Dec 27, 2024

github-actions bot commented Dec 30, 2024

github-actions bot commented Dec 30, 2024

github-actions bot commented Dec 31, 2024

github-actions bot commented Dec 31, 2024

github-actions bot commented Jan 3, 2025

github-actions bot commented Jan 3, 2025

github-actions bot commented Jan 3, 2025

github-actions bot commented Jan 4, 2025

github-actions bot commented Jan 4, 2025

github-actions bot commented Jan 4, 2025

github-actions bot commented Jan 10, 2025

github-actions bot commented Jan 10, 2025

github-actions bot commented Jan 10, 2025

github-actions bot commented Jan 10, 2025

github-actions bot commented Jan 10, 2025

github-actions bot commented Jan 10, 2025

github-actions bot commented Jan 10, 2025

kristinacyin left a comment

Choose a reason for hiding this comment

dave-kennedy-ecs Jan 10, 2025

Choose a reason for hiding this comment

dave-kennedy-ecs left a comment

Choose a reason for hiding this comment

github-actions bot commented Jan 13, 2025

github-actions bot commented Jan 13, 2025

github-actions bot commented Jan 13, 2025

therealslimhsiehdy commented Dec 27, 2024 •

edited

Loading