#2969 - Domains and request table needs visual header - [NL] #3294

CocoByte · 2025-01-03T19:50:43Z

Ticket 2969

Resolves #2969

Changes

In domain request table javascript, combined delete column with action column
Made "Action" header text visible
Force columns of Domain and Domain Request tables in non-org views to align

Context for reviewers

Setup

Ensure org model waffle flags are disabled

Code Review Verification Steps

Go to the Domain and Domain Request table view. Verify that...

"Action" appears in the table header for the last column of both tables
the ANDI output for the "Action" header is "Action"
The delete button appears under the "Action" column instead of its own column
The column widths of the Domain and Domain Request table are aligned

As the original developer, I have

Satisfied acceptance criteria and met development standards

Met the acceptance criteria, or will meet them in a subsequent PR
Created/modified automated tests
Update documentation in READMEs and/or onboarding guide

Ensured code standards are met (Original Developer)

If any updated dependencies on Pipfile, also update dependencies in requirements.txt.
Interactions with external systems are wrapped in try/except
Error handling exists for unusual or missing values

Validated user-facing changes (if applicable)

Tag @dotgov-designers in this PR's Reviewers for design review. If code is not user-facing, delete design reviewer checklist
Verify new pages have been added to .pa11yci file so that they will be tested with our automated accessibility testing
Checked keyboard navigability
Tested general usability, landmarks, page header structure, and links with a screen reader (such as Voiceover or ANDI)

As a code reviewer, I have

Reviewed, tested, and left feedback about the changes

Pulled this branch locally and tested it
Verified code meets all checks above. Address any checks that are not satisfied
Reviewed this code and left comments. Indicate if comments must be addressed before code is merged
Checked that all code is adequately covered by tests
Verify migrations are valid and do not conflict with existing migrations

Validated user-facing changes as a developer

Note: Multiple code reviewers can share the checklists above, a second reviewer should not make a duplicate checklist. All checks should be checked before approving, even those labeled N/A.

New pages have been added to .pa11yci file so that they will be tested with our automated accessibility testing
Checked keyboard navigability
Meets all designs and user flows provided by design/product
Tested general usability, landmarks, page header structure, and links with a screen reader (such as Voiceover or ANDI)
(Rarely needed) Tested as both an analyst and applicant user

As a designer reviewer, I have

Verified that the changes match the design intention

Checked that the design translated visually
Checked behavior. Comment any found issues or broken flows.
Checked different states (empty, one, some, error)
Checked for landmarks, page heading structure, and links

Validated user-facing changes as a designer

Checked keyboard navigability
Tested general usability, landmarks, page header structure, and links with a screen reader (such as Voiceover or ANDI)
Tested with multiple browsers (check off which ones were used)
- Chrome
- Microsoft Edge
- FireFox
- Safari
(Rarely needed) Tested as both an analyst and applicant user

References

Code review best practices

Screenshots

github-actions · 2025-01-03T19:55:02Z

🥳 Successfully deployed to developer sandbox nl.

…headers

github-actions · 2025-01-06T20:43:29Z

🥳 Successfully deployed to developer sandbox nl.

github-actions · 2025-01-07T06:14:15Z

🥳 Successfully deployed to developer sandbox nl.

src/registrar/assets/src/js/getgov/table-domain-requests.js

src/registrar/assets/src/js/getgov/table-domains.js

src/registrar/assets/src/js/getgov/table-domain-requests.js

github-actions · 2025-01-08T01:37:22Z

🥳 Successfully deployed to developer sandbox nl.

github-actions · 2025-01-08T06:10:39Z

🥳 Successfully deployed to developer sandbox nl.

github-actions · 2025-01-08T18:04:40Z

🥳 Successfully deployed to developer sandbox nl.

github-actions · 2025-01-08T18:11:32Z

🥳 Successfully deployed to developer sandbox nl.

github-actions · 2025-01-09T17:20:16Z

🥳 Successfully deployed to developer sandbox nl.

src/registrar/assets/src/js/getgov/table-base.js

rachidatecs

Dave brings up a good point. Revise the var name again (my suggestion was not great), remove a couple of obsolete comments and good to merge.

rachidatecs · 2025-01-10T17:39:49Z

src/registrar/templates/includes/domains_table.html

@@ -214,7 +214,7 @@ <h2>Status</h2>
            scope="col" 
            role="columnheader" 
          >
-            <span class="usa-sr-only">Action</span>
+            Action
          </th>
        </tr>
      </thead>


Remove the comment below: 

I think this comment is still valid. We want to indicate that AJAX builds the table body

rachidatecs · 2025-01-10T17:40:18Z

src/registrar/templates/includes/domain_requests_table.html

@@ -186,7 +186,7 @@ <h2>Status</h2>
                    <th data-sortable="creator" scope="col" role="columnheader">Created by</th>
                    {% endif %}
                    <th data-sortable="status" scope="col" role="columnheader">Status</th>
-                    <th scope="col" role="columnheader"><span class="usa-sr-only">Action</span></th>
+                    <th scope="col" role="columnheader">Action</th>
                    <!-- AJAX will conditionally add a th for delete actions -->


Remove this comment

github-actions · 2025-01-11T04:02:36Z

🥳 Successfully deployed to developer sandbox nl.

Combine action column and delete columns. Make "Action" header visible

7938bbe

CocoByte requested a review from abroddrick as a code owner January 3, 2025 19:50

CocoByte changed the title ~~[DRAFT] Action column~~ #2969 - Domains and request table needs visual header Jan 3, 2025

Merge remote-tracking branch 'origin/main' into nl/2969-visual-table-…

bb7560b

…headers

CocoByte changed the title ~~#2969 - Domains and request table needs visual header~~ #2969 - Domains and request table needs visual header - [NL] Jan 6, 2025

CocoByte added 2 commits January 6, 2025 13:37

Make non-org Domain and Domain Request table columns align

581dc70

Merge remote-tracking branch 'origin/main' into nl/2969-visual-table-…

113575f

…headers

CocoByte requested review from lizpearl, Matt-Spence, rachidatecs, dave-kennedy-ecs, erinysong, asaki222, zandercymatics, SamiyahKey and a team January 6, 2025 20:41

Merge branch 'main' into nl/2969-visual-table-headers

c3aec25

rachidatecs reviewed Jan 7, 2025

View reviewed changes

src/registrar/assets/src/js/getgov/table-domain-requests.js Outdated Show resolved Hide resolved

rachidatecs reviewed Jan 7, 2025

View reviewed changes

src/registrar/assets/src/js/getgov/table-domain-requests.js Outdated Show resolved Hide resolved

rachidatecs reviewed Jan 7, 2025

View reviewed changes

src/registrar/assets/src/js/getgov/table-domains.js Outdated Show resolved Hide resolved

rachidatecs reviewed Jan 7, 2025

View reviewed changes

src/registrar/assets/src/js/getgov/table-domain-requests.js Outdated Show resolved Hide resolved

Merge branch 'main' into nl/2969-visual-table-headers

bff0833

CocoByte added 2 commits January 7, 2025 21:37

PR feedback

018967e

resolved merge conflict

aa01c22

resolved merge conflict

b27f45b

Merge branch 'main' into nl/2969-visual-table-headers

2c96ffd

Merge branch 'main' into nl/2969-visual-table-headers

342d6f2

dave-kennedy-ecs reviewed Jan 10, 2025

View reviewed changes

src/registrar/assets/src/js/getgov/table-base.js Outdated Show resolved Hide resolved

rachidatecs self-assigned this Jan 10, 2025

rachidatecs approved these changes Jan 10, 2025

View reviewed changes

rachidatecs reviewed Jan 10, 2025

View reviewed changes

Rename and cleanup

cad6238

CocoByte merged commit 3c91ea4 into main Jan 11, 2025
10 checks passed

CocoByte deleted the nl/2969-visual-table-headers branch January 11, 2025 04:03

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

#2969 - Domains and request table needs visual header - [NL] #3294

#2969 - Domains and request table needs visual header - [NL] #3294

CocoByte commented Jan 3, 2025 •

edited

Loading

github-actions bot commented Jan 3, 2025

github-actions bot commented Jan 6, 2025

github-actions bot commented Jan 7, 2025

github-actions bot commented Jan 8, 2025

github-actions bot commented Jan 8, 2025

github-actions bot commented Jan 8, 2025

github-actions bot commented Jan 8, 2025

github-actions bot commented Jan 9, 2025

rachidatecs left a comment •

edited

Loading

rachidatecs Jan 10, 2025 •

edited

Loading

CocoByte Jan 11, 2025

rachidatecs Jan 10, 2025

github-actions bot commented Jan 11, 2025

#2969 - Domains and request table needs visual header - [NL] #3294

#2969 - Domains and request table needs visual header - [NL] #3294

Conversation

CocoByte commented Jan 3, 2025 • edited Loading

Ticket 2969

Changes

Context for reviewers

Setup

Code Review Verification Steps

As the original developer, I have

Satisfied acceptance criteria and met development standards

Ensured code standards are met (Original Developer)

Validated user-facing changes (if applicable)

As a code reviewer, I have

Reviewed, tested, and left feedback about the changes

Validated user-facing changes as a developer

As a designer reviewer, I have

Verified that the changes match the design intention

Validated user-facing changes as a designer

References

Screenshots

github-actions bot commented Jan 3, 2025

github-actions bot commented Jan 6, 2025

github-actions bot commented Jan 7, 2025

github-actions bot commented Jan 8, 2025

github-actions bot commented Jan 8, 2025

github-actions bot commented Jan 8, 2025

github-actions bot commented Jan 8, 2025

github-actions bot commented Jan 9, 2025

rachidatecs left a comment • edited Loading

Choose a reason for hiding this comment

rachidatecs Jan 10, 2025 • edited Loading

Choose a reason for hiding this comment

CocoByte Jan 11, 2025

Choose a reason for hiding this comment

rachidatecs Jan 10, 2025

Choose a reason for hiding this comment

github-actions bot commented Jan 11, 2025

CocoByte commented Jan 3, 2025 •

edited

Loading

rachidatecs left a comment •

edited

Loading

rachidatecs Jan 10, 2025 •

edited

Loading