-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#3317: Don't allow non-org model domain requests for federal agencies in a portfolio [ZA] #3408
Merged
+220
−205
Merged
Changes from 1 commit
Commits
Show all changes
23 commits
Select commit
Hold shift + click to select a range
a6de529
Core logic
zandercymatics a4f1abc
add check
zandercymatics 0725447
Merge branch 'main' into za/3317-hide-org-federal-agencies
zandercymatics 297029a
Add UI logic
zandercymatics 1f9efb7
Add unit test for waffle utility
zandercymatics bdb3875
Add tests for unlock_organization_contact
zandercymatics 8504eb1
Merge branch 'main' into za/3317-hide-org-federal-agencies
zandercymatics ad79557
lint and fix test
zandercymatics 0478d2b
Fix unit tests
zandercymatics 4dba0a3
remove test code and lint
zandercymatics b5935a3
lint
zandercymatics cc0c530
Update test_forms.py
zandercymatics 59d1301
Update test_views_request.py
zandercymatics 714a723
lint
zandercymatics b24ab81
Merge branch 'main' into za/3317-hide-org-federal-agencies
zandercymatics f1005f5
Merge branch 'main' into za/3317-hide-org-federal-agencies
zandercymatics e270b8d
Merge branch 'main' into za/3317-hide-org-federal-agencies
zandercymatics 8419d22
Merge branch 'main' into za/3317-hide-org-federal-agencies
zandercymatics d14a236
fix bug
zandercymatics 367b2b8
Requested changes
zandercymatics 05bf5d0
Merge branch 'main' into za/3317-hide-org-federal-agencies
zandercymatics 9bf152a
unit test
zandercymatics 0d1af72
Merge branch 'main' into za/3317-hide-org-federal-agencies
zandercymatics File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Loading status checks…
lint and fix test
commit ad79557a55598cc4f67c33d11b01acf76a7024be
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@zandercymatics why not just check the federal agency value against the federal agency value on the portfolio? This avoids the risk of the org name naming convention changing in the future and this breaking silently
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@abroddrick Good point! I'll implement this