Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sort hook ids in each pre-commit hook entry #194

Merged
merged 1 commit into from
Oct 30, 2024
Merged

Sort hook ids in each pre-commit hook entry #194

merged 1 commit into from
Oct 30, 2024

Conversation

mcdonnnj
Copy link
Member

🗣 Description

This pull request ensures that all hook ids in a given hook entry in our pre-commit configuration are sorted alphabetically.

💭 Motivation and context

This is our standard practice and this just ensures that all hook entries are consistent now.

🧪 Testing

Automated tests pass.

✅ Pre-approval checklist

  • This PR has an informative and human-readable title.
  • Changes are limited to a single goal - eschew scope creep!
  • All relevant type-of-change labels have been added.
  • I have read the CONTRIBUTING document.
  • These code changes follow cisagov code standards.
  • All new and existing tests pass.

@mcdonnnj
Sort hook ids in each pre-commit hook entry
1d285f2 
Ensure that all hook ids are sorted alphabetically in each hook entry
in our pre-commit configuration.
@mcdonnnj mcdonnnj added improvement This issue or pull request will add or improve functionality, maintainability, or ease of use dependencies Pull requests that update a dependency file labels Oct 29, 2024
@mcdonnnj mcdonnnj requested a review from a team October 29, 2024 20:40
@mcdonnnj mcdonnnj self-assigned this Oct 29, 2024
dav3r
dav3r approved these changes Oct 29, 2024
View reviewed changes
Copy link
Member

@dav3r dav3r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

MOAR SORTING! 🔡

@mcdonnnj mcdonnnj added kraken 🐙 This pull request is ready to merge during the next Lineage Kraken release hacktoberfest-accepted Pull request that should count toward Hacktoberfest participation labels Oct 29, 2024
@mcdonnnj mcdonnnj added this pull request to the merge queue Oct 30, 2024
Merged via the queue into develop with commit f517db7 Oct 30, 2024
4 checks passed
@mcdonnnj mcdonnnj deleted the improvement/ensure_pre-commit_hooks_are_sorted branch October 30, 2024 05:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jsf9k jsf9k jsf9k approved these changes

@dav3r dav3r dav3r approved these changes

@dv4harr10 dv4harr10 dv4harr10 approved these changes

@felddy felddy Awaiting requested review from felddy felddy is a code owner

Assignees

@mcdonnnj mcdonnnj

Labels
dependencies Pull requests that update a dependency file hacktoberfest-accepted Pull request that should count toward Hacktoberfest participation improvement This issue or pull request will add or improve functionality, maintainability, or ease of use kraken 🐙 This pull request is ready to merge during the next Lineage Kraken release
Projects
Skeleton Maintenance
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mcdonnnj @jsf9k @dav3r @dv4harr10