Connects the Google Contact Form #751
Conversation
|
@nrrao Thanks for catching that. I centered it. |
|
@maxskewes thanks! does this mean we're able to upload an image? |
There was a problem hiding this comment.
@maxskewes, The form is center now. Since there is commented code should we make a separate file before merging?
Also,
frameborder='0'
marginheight='0'
marginwidth='0' should be frameBorder,marginHeight,marginWidth to avoid console warning messages.
iframe should have title property to avoid warning message.
Created ContactForm component to be used when no longer using the Google Contact Form. Removed commented code from index.js. Added title to <iframe> tag and corrected jsx syntax.
|
I have updated the PR. I removed the commented code from index.js, created a separate ContactForm component to be used when we are no longer using the Google form, corrected code for the iframe tag. |
![codeclimate[bot]](https://avatars.githubusercontent.com/in/9403?s=60&v=4){kind=small}
| @@ -133,18 +57,32 @@ const Contact = () => { | |||
|
|
|||
| return ( | |||
| <Box> | |||
| <GenericHeaderSection mainTitle='Contact Us' breadCrumbLinks={breadCrumbLinks}> | |||
| <GenericHeaderSection | |||
There was a problem hiding this comment.
Identical blocks of code found in 2 locations. Consider refactoring.
|
|
||
| return ( | ||
| <Box> | ||
| <GenericHeaderSection |
There was a problem hiding this comment.
Identical blocks of code found in 2 locations. Consider refactoring.
|
@mariastudnicka The uploading of the image is taking place on a different page and is not part of this pull request. |
Changed <div> to <Card> and added <CardMedia> to make google form responsive. Deleted all trace of defunct 'addPad' prop.
|
Code Climate has analyzed commit a22ef50 and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (50% is the threshold). This pull request will bring the total coverage in the repository to 72.6% (0.0% change). View more on Code Climate. |
Puts a, <iframe> tag to a google contact form
Closes issue #604