Kotlin serialization custom discriminator name #343
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
cjbooms
reviewed
Dec 20, 2024
...c/test/kotlin/com/cjbooms/fabrikt/models/kotlinx/KotlinxSerializationOneOfPolymorphicTest.kt
Show resolved
Hide resolved
cjbooms
approved these changes
Dec 20, 2024
Kotlin Serialization by default uses `type` for the JSON class discriminator property and thus we need to specify the property name explicitly when it is not `type`. Note that `JsonClassDiscriminator` is part of the experimental serialization API and requires opt-in from the user.
ulrikandersen
force-pushed
the
kotlin-serialization-custom-discriminator-name
branch
from
cd2c6e4 to
e9be32a
Compare
ulrikandersen
deleted the
kotlin-serialization-custom-discriminator-name
branch
Thanks 🙏 What a way to end the year 🎊 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for polymorphic discriminators with names other than "type", which is the default class discriminator used by Kotlin serialization.
Non-default class disciminators are defined using the
JsonClassDiscriminatorannotation (docs) and requires opt-in by the user.