Configurable map #36
Open
Configurable map #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amercader
reviewed
Oct 17, 2016
| var baseLayerUrl; | ||
| var attribution; | ||
|
|
||
| if (mapBaseLayerConfig.type == 'custom') { |
There was a problem hiding this comment.
Let's add the mapbox option to keep it consistent with the rest of spatial widgets
|
@duskobogdanovski @mbocevski Are you guys using this extension? No one is currently looking after it so I'm more than happy to add you as administrators so you can maintain it properly. Let me know. |
|
@amercader Yeah we have several places where this is used. Feel free to add as admins so we can maintain it properly. Thanks. |
|
Perfect, done! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add configuration for map base layer