Skip to content

Commit

Permalink
Version string is now the same in setup.py and __init__.py
Browse files Browse the repository at this point in the history
  • Loading branch information
@clade
clade committed Nov 13, 2018
1 parent 0b6e3db commit 62c0a7f
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 2 deletions.
2 changes: 1 addition & 1 deletion PyDAQmx/__init__.py
View file
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@
globals()[new_name] = globals()[name]


__version_info__ = (1, 4)
__version_info__ = (1, 4, 2)
__version__ = '.'.join(str(num) for num in __version_info__)

__author__ =u'Pierre Cladé'
3 changes: 2 additions & 1 deletion setup.py
View file
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
from setuptools import setup
from setuptools.command.test import test as TestCommand

version = '1.4.1'
version = '1.4.2'

import os
directory = os.path.split(os.path.realpath(__file__))[0]
Expand Down Expand Up @@ -113,6 +113,7 @@ def run_tests(self):
===============
Main changes:
* 1.4.2 Proper version string
* 1.4.1 NIDAQmx Base supported on 64bits linux
* 1.4 Many small improvements
* 1.3.2 bug fix
Expand Down

2 comments on commit 62c0a7f

@petebachant
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not import this variable directly so it doesn't need to be changed in two places?

@clade
Copy link
Owner Author

@clade clade commented on 62c0a7f Nov 13, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't want to import PyDAQmx from the setup.py because this will require NIDAQmx to be installed (which may not be the case). I will implement the solution suggested by @chrisjbillington in #52

Please sign in to comment.