Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SendableItemMetadata #44

Merged
merged 27 commits into from
Jan 23, 2025
Merged

Add SendableItemMetadata #44

merged 27 commits into from
Jan 23, 2025

Conversation

claucambra
Copy link
Owner

Part of Swift 6 migration

Allows way of providing item metadata across NCFPK in a fully thread-safe manner

Signed-off-by: Claudio Cambra <[email protected]>

Remove unnecessary childitems private method

Signed-off-by: Claudio Cambra <[email protected]>

f2

Signed-off-by: Claudio Cambra <[email protected]>

f

Signed-off-by: Claudio Cambra <[email protected]>
…ng "var"

Prepare for refactoring to struct

Signed-off-by: Claudio Cambra <[email protected]>
Create a standard protocol that both conform to and make
SendableItemMetadata *actually* sendable by making it a struct

Signed-off-by: Claudio Cambra <[email protected]>
@claucambra claucambra added enhancement New feature or request swift-6 labels Jan 21, 2025
@claucambra claucambra added this to the 2.0.0 milestone Jan 21, 2025
@claucambra claucambra self-assigned this Jan 21, 2025
@codecov-commenter
Copy link

codecov-commenter commented Jan 21, 2025

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 91.00257% with 70 lines in your changes missing coverage. Please review.

Project coverage is 78.90%. Comparing base (6491529) to head (0c68266).
Report is 30 commits behind head on main.

Files with missing lines Patch % Lines
...xtcloudFileProviderKit/Metadata/ItemMetadata.swift 88.37% 30 Missing ⚠️
Sources/NextcloudFileProviderKit/Item/Item.swift 49.01% 26 Missing ⚠️
...ces/NextcloudFileProviderKit/Item/Item+Fetch.swift 50.00% 4 Missing ⚠️
...ileProviderKit/Database/FilesDatabaseManager.swift 90.00% 3 Missing ⚠️
...roviderKit/Enumeration/Enumerator+SyncEngine.swift 85.71% 2 Missing ⚠️
...es/NextcloudFileProviderKit/Item/Item+Create.swift 93.93% 2 Missing ⚠️
...es/NextcloudFileProviderKit/Item/Item+Modify.swift 83.33% 2 Missing ⚠️
...FileProviderKit/Extensions/NKFile+Extensions.swift 98.61% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #44      +/-   ##
==========================================
+ Coverage   78.80%   78.90%   +0.09%     
==========================================
  Files          49       50       +1     
  Lines       10913    10839      -74     
==========================================
- Hits         8600     8552      -48     
+ Misses       2313     2287      -26     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@claucambra claucambra merged commit b768bd7 into main Jan 23, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request swift-6
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants