Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

github action for testing builds #83

Merged

Conversation

mathematicalmichael
Copy link
Contributor

I put in PR #82 but wanted a way to get feedback on the build process, so I added CI.

had to add --legacy-peer-deps bc npm ci threw the following:

npm error code ERESOLVE
npm error ERESOLVE could not resolve
npm error
npm error While resolving: @ngneat/[email protected]
npm error Found: @angular/[email protected]
npm error node_modules/@angular/platform-browser-dynamic
npm error   @angular/platform-browser-dynamic@"^17.3.7" from the root project
npm error
npm error Could not resolve dependency:
npm error peer @angular/platform-browser-dynamic@"13.3.5" from @ngneat/[email protected]
npm error node_modules/@ngneat/dag
npm error   @ngneat/dag@"^2.0.0" from the root project
npm error
npm error Conflicting peer dependency: @angular/[email protected]
npm error node_modules/@angular/platform-browser-dynamic
npm error   peer @angular/platform-browser-dynamic@"13.3.5" from @ngneat/[email protected]
npm error   node_modules/@ngneat/dag
npm error     @ngneat/dag@"^2.0.0" from the root project
npm error
npm error Fix the upstream dependency conflict, or retry
npm error this command with --force or --legacy-peer-deps
npm error to accept an incorrect (and potentially broken) dependency resolution.
npm error
npm error
npm error For a full report see:
npm error /home/runner/.npm/_logs/2024-06-27T21_36_33_667Z-eresolve-report.txt

Let me know if I should also update the README to add the required flag.

@shyallegro
Copy link
Contributor

shyallegro commented Jul 1, 2024

seems we forgot to push the .nprc file with legacy-peer-deps, which handle this issue

@mathematicalmichael
Copy link
Contributor Author

seems we forgot to push the .nprc file with legacy-peer-deps, which handle this issue

would you like me to modify the action to remove that flag? or just close this out entirely?

@shyallegro
Copy link
Contributor

@mathematicalmichael the actions is a good idea, i'll push the .npmrc file, so you can remove the flag

@mathematicalmichael mathematicalmichael force-pushed the feature/gh-action-build branch 3 times, most recently from 43f3b4f to 5fe21fc Compare July 1, 2024 20:05
@mathematicalmichael
Copy link
Contributor Author

mathematicalmichael commented Jul 1, 2024

I rebased from your branch and then removed the irrelevant commits to keep history clean / enable fast-fwd merges.

Evidence of action running after the rebase: mathematicalmichael#2

@mathematicalmichael mathematicalmichael force-pushed the feature/gh-action-build branch 2 times, most recently from 450654f to 12c609f Compare July 1, 2024 23:25
@mathematicalmichael mathematicalmichael force-pushed the feature/gh-action-build branch from 12c609f to e28497e Compare July 1, 2024 23:26
@jkhenning jkhenning merged commit dff8c56 into clearml:master Jul 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants