New workflow which verifies sha hashes in CI #25
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bfops
reviewed
Jan 15, 2025
bfops
approved these changes
Jan 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a CI step which verifies the hashes in the homebrew file to make sure they are correct before merging. We should probably add this as a required CI step but I am only proposing the workflow for now.
Testing
This PR (which is based on this PR) introduces sha breakages and it fails the CI: #26
ARM failure: https://github.com/clockworklabs/homebrew-tap/actions/runs/12787845883/job/35647899457
AMD failure: https://github.com/clockworklabs/homebrew-tap/actions/runs/12787873020/job/35647982860