Fix warning messages in config.go and client.go #1963
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
hanizang77
commented
Feb 3, 2025
hanizang77
commented
- Fix non-constant format string warning in config.go fmt.Errorf calls
- Fix integer format specifier in client.go Printf statement
hanizang77
requested review from
seokho-son,
yunkon-kim and
sykim-etri
as code owners
seokho-son
reviewed
Feb 3, 2025
There was a problem hiding this comment.
@hanizang77 기여 감사합니다! 마이너한 코멘트가 있습니다. 살펴보시고 필요시 적절히 업데이트해주세요.
src/core/common/config.go
Outdated
| errString := id + " config is not found from Key-value store. Envirionment variable will be used." | ||
|
|
||
| const errMsgFormat = "%s config is not found from Key-value store. Environment variable will be used." | ||
| errString := fmt.Sprintf(errMsgFormat, id) |
There was a problem hiding this comment.
errMsgFormat 가 이후에도 재사용되지 않는다면 굳이 상수로 지정할 필요가 있을까요?
errString := fmt.Sprintf(메시지, id) 로 정리해도, 코드 길이를 줄일 수 있어서 좋을 것 같긴합니다. :)
There was a problem hiding this comment.
github가 익숙치 않아 보여드리고 싶지 않았던 시험작이 Commit되고 말았군요. 말씀하신것처럼 굳이 상수로 지정할 필요가 없습니다.
src/core/common/config.go
Outdated
|
|
||
| const errMsgFormat = "%s config is not found from Key-value store. Environment variable will be used." | ||
| errString := fmt.Sprintf(errMsgFormat, id) | ||
| // errString := id + " config is not found from Key-value store. Envirionment variable will be used." |
There was a problem hiding this comment.
주석 처리는 필요 없는 항목인 것 같습니다. 삭제해주세요. ^^
There was a problem hiding this comment.
주석 삭제하고 새로운 버전으로 Commit 하겠습니다.
|
@hanizang77 커밋 스쿼싱 가능하신가요~? :) |
- Fix non-constant format string warning in config.go fmt.Errorf calls - Fix integer format specifier in client.go Printf statement
|
@seokho-son 스쿼시해서 force-push 했습니다 :-) |
|
/approve |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
github-actions
bot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.