Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert dependency updates #366

Merged
merged 2 commits into from
Sep 4, 2024
Merged

Revert dependency updates #366

merged 2 commits into from
Sep 4, 2024

Conversation

markdboyd
Copy link
Contributor

Changes proposed in this pull request:

Reverts #364 and #365

We cannot upgrade to cryptography > 43 at this time because:

Things to check

  • For any logging statements, is there any chance that they could be logging sensitive data?
  • Are log statements using a logging library with a logging level set? Setting a logging level means that log statements "below" that level will not be written to the output. For example, if the logging level is set to INFO and debugging statements are written with log.debug or similar, then they won't be written to the otput, which can prevent unintentional leaks of sensitive data.

Security considerations

We are rolling back to a version of cryptography with known security alerts, but we have no choice until certbot/josepy#181 is resolved, which will happen when certbot/josepy#182 is merged.

@markdboyd markdboyd requested a review from a team as a code owner September 4, 2024 18:16
@markdboyd markdboyd merged commit c25e0f2 into main Sep 4, 2024
1 check passed
@markdboyd markdboyd deleted the revert-dependency-updates branch September 4, 2024 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants