Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this pull request:
There's some pretty extensive refactoring in this PR, namely:
environment
tag key came from a property on theCFTagManager
struct rather than an argument toGenerateTags
CFNameResolver
toCFResourceGetter
CFResourceGetter
functions to return the CF resource, not just the resource nameGenerateTags
, add the ability to look up the space and org for an instance and thus set tags for them whengetMissingResources = true
. This helps in the context of a bind request to the broker, where there is no information about the space or org provided in the request, but we may still want to tag generated AWS resources with information about the org and spaceGenerateTags
to accept a struct of GUIDs asResourceGUIDs
rather than separate positional arguments for each GUIDThings to check
INFO
and debugging statements are written withlog.debug
or similar, then they won't be written to the otput, which can prevent unintentional leaks of sensitive data.Security considerations
No security considerations, just refactoring how tags are generated for AWS resources