Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update delete logic to handle missing bucket #83

Merged
merged 2 commits into from
Jun 25, 2024
Merged

Conversation

markdboyd
Copy link
Contributor

@markdboyd markdboyd commented Jun 25, 2024

Changes proposed in this pull request:

Related to #84

While trying to delete an S3 service, somehow the broker has gotten into a state where the bucket is already deleted, but the service still exists in CF. In this state, subsequent delete-service attempts fail because the deleteBucketContents function does not handle the case where the bucket does not exist. If the bucket does not exist, the deleteBucketContents should not an error and just continue

  • update delete objects logic to handle case where bucket does not exist
  • update unit tests

Things to check

  • For any logging statements, is there any chance that they could be logging sensitive data?
  • Are log statements using a logging library with a logging level set? Setting a logging level means that log statements "below" that level will not be written to the output. For example, if the logging level is set to INFO and debugging statements are written with log.debug or similar, then they won't be written to the otput, which can prevent unintentional leaks of sensitive data.

Security considerations

No expected security changes, just hopefully resolving a broker bug

@markdboyd markdboyd requested a review from a team as a code owner June 25, 2024 18:02
@markdboyd markdboyd requested a review from jameshochadel June 25, 2024 19:23
@markdboyd markdboyd merged commit b846975 into main Jun 25, 2024
@markdboyd markdboyd deleted the fix-delete-logic branch June 25, 2024 19:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants