Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

set custom "User-Agent" for ExApps #329

Merged
merged 1 commit into from
Jan 19, 2025
Merged

set custom "User-Agent" for ExApps #329

merged 1 commit into from
Jan 19, 2025

Conversation

bigcat88
Copy link
Contributor

Fixes #327

Changes proposed in this pull request:

  • Added a custom header in the format ExApp/test-deploy/1.1.0 (httpx/0.24.1) to help "system administrators" identify which requests are taking a long time to complete.

Copy link

codecov bot commented Jan 19, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.69%. Comparing base (301296d) to head (c7545f8).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #329   +/-   ##
=======================================
  Coverage   94.68%   94.69%           
=======================================
  Files          46       46           
  Lines        5367     5368    +1     
=======================================
+ Hits         5082     5083    +1     
  Misses        285      285           
Files with missing lines Coverage Δ
nc_py_api/_session.py 96.48% <100.00%> (+0.01%) ⬆️

@bigcat88 bigcat88 merged commit 19fe459 into main Jan 19, 2025
20 checks passed
@bigcat88 bigcat88 deleted the feat/ex-app/user-agent branch January 19, 2025 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Send exApp name and version in User-Agent header for requests to nextcloud
1 participant