Add configurable sleep/timeout for GCP VPC peering #247
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
dentarg
reviewed
Dec 15, 2023
docs/resources/vpc_gcp_peering.md
Outdated
Comment on lines
283
to
294
| ## Changelog | ||
|
|
||
| List of changes made to this resource for different versions. | ||
|
|
||
| [v1.29.0](https://github.com/cloudamqp/terraform-provider-cloudamqp/releases/tag/v1.29.0) configurable | ||
| sleep and timeout for retries when requesting and reading peering. | ||
|
|
||
| [v1.28.0](https://github.com/cloudamqp/terraform-provider-cloudamqp/releases/tag/v1.18.0) | ||
| Added `wait_on_peering_status` as optional, set to wait until peering is finished. | ||
|
|
||
| [v1.16.0](https://github.com/cloudamqp/terraform-provider-cloudamqp/releases/tag/v1.16.0) | ||
| deprecated intance_id and use vpc_id instead |
There was a problem hiding this comment.
I see we are discussing this at #246 (comment) :)
dentarg
approved these changes
Dec 15, 2023
|
@tbroden84 I think we should be able to have passing builds before merging here if we always merge / bump go-api first? |
|
@dentarg yes, my bad this time. Added both PRs in https://github.com/84codes/go-api/releases/tag/v1.15.0, instead of doing two releases. This caused dependency issues for |
|
I see, and we made changes in go-api so it wasn't compatible with main branch either, but that was resolved by f4c76b3 Okay no worries :) |
|
Yes correct. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
Reported issues about "Timeout talking to backend" and lack of retries when requesting VPC peering.
Part of: #242
Requires: 84codes/go-api#43
WHAT is this pull request doing?
HOW can this pull request be tested?
Manual run a workflow with VPC peering to another VPC hosted in GCP.