Post Go-API import modifications #284
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make the client library more coherent and follow the same structure - Declare variable within var() - Make request - Switch statement to handle response
Updates map[string]interface{} and similar to instead use the any alias.
|
Oh, the changes to |
Removes the dependency to the separated go-api client library as it is now included directly in the provider. Co-authored-by: Tobias Brodén <[email protected]>
|
I extracted those changes by hand and added them here. CI is green 🥳 Please test this as I haven't @tbroden84 :) |
This was referenced Jun 7, 2024
|
@dentarg GJ! Will do. |
tbroden84
approved these changes
Jun 10, 2024
There was a problem hiding this comment.
Tried a subset of the tests with real requests together with some manual ones. Looking good to me.
List of the subset tests used.
TestAccAlarm_Basic
TestAccInstance_Basic
TestAccExtraDiskSize_AWS_Basic
TestAccIntegrationLog_Basic
TestAccRabbitMqConfiguration_Basic
TestAccFirewall_Basic
TestAccVpcConnect_AWS_Basic
TestAccVpcConnect_GCP_Basic
TestAccVpcConnect_Azure_Basic
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
#282 imported https://github.com/84codes/go-api with history
#273 makes some changes to the library code, the commits are cherry-picked from that branch
WHAT is this pull request doing?
HOW can this pull request be tested?