Enable import of VPC peering resource for GCP #308
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tbroden84
added a commit
that referenced
this pull request
Dec 20, 2024
### WHY are these changes introduced? The resource `cloudamqp_vpc_peering` lacks import functionality. This got requested way back in: #158. We found a way to enable this for GCP #308, take a similar approach for AWS. ### WHAT is this pull request doing? - Adds import functionality to the `cloudamqp_vpc_peering` resource - Updates documentation - Adds Go VCR test for accept and import ### HOW can this pull request be tested? Run VCR test for accepting the peering and importing the resource. Limited from the complete flow to not mix in the AWS provider in the test.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
The resource
cloudamqp_vpc_gcp_peeringlacks import functionality and got requested in #307. Without having this, the resource needs to be re-created. Meaning the peering will be removed before added again. This causes downtime, when just to synchronizing the state.WHAT is this pull request doing?
cloudamqp_vpc_gcp_peeringresourceHOW can this pull request be tested?
Run VCR test.