Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: import dependencies into the source tree, with Lucene artifacts #101

Closed
wants to merge 2 commits into from

Conversation

pgj
Copy link
Contributor

@pgj pgj commented Feb 5, 2025

This is a potential variation on #100 with artifacts for Apache Lucene included in the tree.

There is no need to host many of the customized dependencies of
Clouseau in separate repositories as well as produce packages for
them separately.  They are not used by other applications and they
come with a lot of unused parts that are better to be trimmed
anyway.

The following trees are being added here:

- https://github.com/boundary/logula @ `logula_slf4j_2.9.1-2.1.3-p01`
- https://github.com/cloudant/JCTools @ 010666e9
- https://github.com/cloudant/overlock @ cf6d7f71
- https://github.com/cloudant/scalang @ 15c8e17b

From `JCTools`, only specific classes are included from the
`jctools-core` module.
@jaydoane
Copy link
Contributor

jaydoane commented Feb 5, 2025

Built this and ran ./runtesty.py --flaky-retries=0 -f ~/.config/testy/localhost-relengtest001.json -f suites/search.json 👍

=================================================== 264 passed, 8 skipped, 10 xfailed, 5 warnings in 489.04s (0:08:09) ====================================================

With this change, can/should the existing Lucene code scanner be pointed to this repo?

@pgj
Copy link
Contributor Author

pgj commented Feb 5, 2025

With this change, can/should the existing Lucene code scanner be pointed to this repo?

Mind that only the Lucene JARs are imported in the PR, not the source code. I think the code scanner has to interact with the sources themselves.

@pgj pgj force-pushed the import-dependencies+lucene-jars branch from ae465e3 to d219ef7 Compare February 5, 2025 21:18
@pgj
Copy link
Contributor Author

pgj commented Feb 5, 2025

Apparently I made a mistake... I did not add the change for pom.xml to use the 4.6.1-cloudant1 version of the JARs. Now this has been fixed.

@jaydoane
Copy link
Contributor

jaydoane commented Feb 5, 2025

Apparently I made a mistake... I did not add the change for pom.xml to use the 4.6.1-cloudant1 version of the JARs. Now this has been fixed.

Nice save! Seeing this now:

Downloading from project.local: file:/Users/jay/repos/clouseau/repo/org/apache/lucene/lucene-core/4.6.1-cloudant1/lucene-core-4.6.1-cloudant1.pom

Search suite tests still passing 😅

@pgj pgj force-pushed the import-dependencies+lucene-jars branch 4 times, most recently from a596c88 to d219ef7 Compare February 5, 2025 23:27
@pgj pgj force-pushed the import-dependencies+lucene-jars branch from d219ef7 to 60d75fe Compare February 5, 2025 23:35
@pgj
Copy link
Contributor Author

pgj commented Feb 11, 2025

Closing in favor of #102.

@pgj pgj closed this Feb 11, 2025
@pgj pgj deleted the import-dependencies+lucene-jars branch February 11, 2025 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants