Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix vulnerability in babel dependency #52

Merged
merged 3 commits into from
Jan 29, 2024
Merged

Fix vulnerability in babel dependency #52

merged 3 commits into from
Jan 29, 2024

Conversation

armfazh
Copy link
Contributor

@armfazh armfazh commented Jan 25, 2024

changes:

  • removes babel vuln dependency
  • bumps dependencies.
  • removes tsx dependency.

@armfazh armfazh requested review from cdrubin and thibmeu January 25, 2024 19:00
@thibmeu
Copy link
Contributor

thibmeu commented Jan 26, 2024

what's the reasoning behind removing tsx dependency? I like @cloudflare/voprf-ts instead of ../src in the example, it's something users can directly copy.

@armfazh
Copy link
Contributor Author

armfazh commented Jan 26, 2024

the fewer dependencies the better.
if it compiles directly with the Typescript compiler (tsc ), it will do with wrapper tools; but the opposite is not guaranteed
also we want to test/bench theactual javascript code, using node directly: $ node file.js , instead of $ node -t <tool> file.ts .

@armfazh armfazh merged commit 9292a11 into main Jan 29, 2024
5 checks passed
@armfazh armfazh deleted the fixVulnBabel branch January 29, 2024 20:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants