Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(wrangler): Drop worker prefix when creating KV namespaces #7759

Open
wants to merge 1 commit into
base: next
Choose a base branch
from

Conversation

pmiguel
Copy link
Contributor

@pmiguel pmiguel commented Jan 14, 2025

Fixes #DEVX-1551

Changes the default behaviour of wrangler kv namespace create to not prefix the worker name to the namespace name.

  • Tests
    • TODO (before merge)
    • Tests included
    • Tests not necessary because:
  • E2E Tests CI Job required? (Use "e2e" label or ask maintainer to run separately)
    • I don't know
    • Required
    • Not required because: no contract change with target API.
  • Public documentation
    • TODO (before merge)
    • Cloudflare docs PR(s):
    • Documentation not necessary because: will update before v4 releases.

@pmiguel pmiguel requested review from a team as code owners January 14, 2025 13:23
Copy link

changeset-bot bot commented Jan 14, 2025

🦋 Changeset detected

Latest commit: 3a68ef4

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
wrangler Major
@cloudflare/vitest-pool-workers Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

github-actions bot commented Jan 14, 2025

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12867026577/npm-package-wrangler-7759

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/7759/npm-package-wrangler-7759

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12867026577/npm-package-wrangler-7759 dev path/to/script.js
Additional artifacts:
npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12867026577/npm-package-create-cloudflare-7759 --no-auto-update
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12867026577/npm-package-cloudflare-kv-asset-handler-7759
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12867026577/npm-package-miniflare-7759
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12867026577/npm-package-cloudflare-pages-shared-7759
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12867026577/npm-package-cloudflare-vitest-pool-workers-7759
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12867026577/npm-package-cloudflare-workers-editor-shared-7759
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12867026577/npm-package-cloudflare-workers-shared-7759
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12867026577/npm-package-cloudflare-workflows-shared-7759

Note that these links will no longer work once the GitHub Actions artifact expires.


[email protected] includes the following runtime dependencies:

Package Constraint Resolved
miniflare workspace:* 3.20241106.1
workerd 1.20241106.1 1.20241106.1
workerd --version 1.20241106.1 2024-11-06

Please ensure constraints are pinned, and miniflare/workerd minor versions match.

@pmiguel pmiguel force-pushed the pleal/wrangler-next-drop-worker-prefix-kv-namespace branch from 4d9828e to 3a68ef4 Compare January 20, 2025 11:27
@penalosa penalosa added this to the Wrangler v4 milestone Feb 3, 2025
@penalosa penalosa added the breaking change Change that will result in breaking existing behavior label Feb 3, 2025
@pmiguel pmiguel force-pushed the pleal/wrangler-next-drop-worker-prefix-kv-namespace branch from 3a68ef4 to 7cd8429 Compare February 10, 2025 15:45
@lrapoport-cf lrapoport-cf added the caretaking Priority for caretaking label Feb 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking change Change that will result in breaking existing behavior caretaking Priority for caretaking
Projects
Status: Approved
Development

Successfully merging this pull request may close these issues.

3 participants