-
Notifications
You must be signed in to change notification settings - Fork 770
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update experimental Next.js template to work on @opennextjs/[email protected]
#7903
Conversation
dario-piotrowicz
commented
Jan 24, 2025
•
edited
Loading
edited
- Tests
- TODO (before merge)
- Tests included
- Tests not necessary because: The experimental Next.js c3 template already has e2es
- E2E Tests CI Job required? (Use "e2e" label or ask maintainer to run separately)
- I don't know
- Required
- Not required because: This is a C3 only change
- Public documentation
- TODO (before merge)
- Cloudflare docs PR(s):
- Documentation not necessary because: OpenNext docs updated instead cloudflare: update docs to 0.4 opennextjs/docs#57
🦋 Changeset detectedLatest commit: b8d42f6 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
A wrangler prerelease is available for testing. You can install this latest build in your project with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13030702998/npm-package-wrangler-7903 You can reference the automatically updated head of this PR with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/7903/npm-package-wrangler-7903 Or you can use npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13030702998/npm-package-wrangler-7903 dev path/to/script.js Additional artifacts:cloudflare-workers-bindings-extension: wget https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13030702998/npm-package-cloudflare-workers-bindings-extension-7903 -O ./cloudflare-workers-bindings-extension.0.0.0-ved7e68573.vsix && code --install-extension ./cloudflare-workers-bindings-extension.0.0.0-ved7e68573.vsix create-cloudflare: npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13030702998/npm-package-create-cloudflare-7903 --no-auto-update @cloudflare/kv-asset-handler: npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13030702998/npm-package-cloudflare-kv-asset-handler-7903 miniflare: npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13030702998/npm-package-miniflare-7903 @cloudflare/pages-shared: npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13030702998/npm-package-cloudflare-pages-shared-7903 @cloudflare/unenv-preset: npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13030702998/npm-package-cloudflare-unenv-preset-7903 @cloudflare/vite-plugin: npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13030702998/npm-package-cloudflare-vite-plugin-7903 @cloudflare/vitest-pool-workers: npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13030702998/npm-package-cloudflare-vitest-pool-workers-7903 @cloudflare/workers-editor-shared: npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13030702998/npm-package-cloudflare-workers-editor-shared-7903 @cloudflare/workers-shared: npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13030702998/npm-package-cloudflare-workers-shared-7903 @cloudflare/workflows-shared: npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13030702998/npm-package-cloudflare-workflows-shared-7903 Note that these links will no longer work once the GitHub Actions artifact expires.
Please ensure constraints are pinned, and |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
909b412
to
ae9e7ce
Compare
ae9e7ce
to
b8d42f6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - just re-running the C3 bun checks since they flaked.