Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update experimental Next.js template to work on @opennextjs/[email protected] #7903

Merged
merged 1 commit into from
Jan 29, 2025

Conversation

dario-piotrowicz
Copy link
Member

@dario-piotrowicz dario-piotrowicz commented Jan 24, 2025


  • Tests
    • TODO (before merge)
    • Tests included
    • Tests not necessary because: The experimental Next.js c3 template already has e2es
  • E2E Tests CI Job required? (Use "e2e" label or ask maintainer to run separately)
    • I don't know
    • Required
    • Not required because: This is a C3 only change
  • Public documentation

Copy link

changeset-bot bot commented Jan 24, 2025

🦋 Changeset detected

Latest commit: b8d42f6

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
create-cloudflare Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

github-actions bot commented Jan 24, 2025

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13030702998/npm-package-wrangler-7903

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/7903/npm-package-wrangler-7903

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13030702998/npm-package-wrangler-7903 dev path/to/script.js
Additional artifacts:

cloudflare-workers-bindings-extension:

wget https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13030702998/npm-package-cloudflare-workers-bindings-extension-7903 -O ./cloudflare-workers-bindings-extension.0.0.0-ved7e68573.vsix && code --install-extension ./cloudflare-workers-bindings-extension.0.0.0-ved7e68573.vsix

create-cloudflare:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13030702998/npm-package-create-cloudflare-7903 --no-auto-update

@cloudflare/kv-asset-handler:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13030702998/npm-package-cloudflare-kv-asset-handler-7903

miniflare:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13030702998/npm-package-miniflare-7903

@cloudflare/pages-shared:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13030702998/npm-package-cloudflare-pages-shared-7903

@cloudflare/unenv-preset:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13030702998/npm-package-cloudflare-unenv-preset-7903

@cloudflare/vite-plugin:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13030702998/npm-package-cloudflare-vite-plugin-7903

@cloudflare/vitest-pool-workers:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13030702998/npm-package-cloudflare-vitest-pool-workers-7903

@cloudflare/workers-editor-shared:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13030702998/npm-package-cloudflare-workers-editor-shared-7903

@cloudflare/workers-shared:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13030702998/npm-package-cloudflare-workers-shared-7903

@cloudflare/workflows-shared:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13030702998/npm-package-cloudflare-workflows-shared-7903

Note that these links will no longer work once the GitHub Actions artifact expires.


[email protected] includes the following runtime dependencies:

Package Constraint Resolved
miniflare workspace:* 3.20250124.0
workerd 1.20250124.0 1.20250124.0
workerd --version 1.20250124.0 2025-01-24

Please ensure constraints are pinned, and miniflare/workerd minor versions match.

Copy link
Contributor

@vicb vicb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@dario-piotrowicz dario-piotrowicz force-pushed the dario/c3/open-next-0.4.x branch 2 times, most recently from 909b412 to ae9e7ce Compare January 27, 2025 21:54
@dario-piotrowicz dario-piotrowicz marked this pull request as ready for review January 27, 2025 22:04
@dario-piotrowicz dario-piotrowicz requested review from a team as code owners January 27, 2025 22:04
@petebacondarwin petebacondarwin force-pushed the dario/c3/open-next-0.4.x branch from ae9e7ce to b8d42f6 Compare January 29, 2025 11:51
Copy link
Contributor

@petebacondarwin petebacondarwin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - just re-running the C3 bun checks since they flaked.

@dario-piotrowicz dario-piotrowicz merged commit ce8bfbd into main Jan 29, 2025
26 checks passed
@dario-piotrowicz dario-piotrowicz deleted the dario/c3/open-next-0.4.x branch January 29, 2025 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants