-
Notifications
You must be signed in to change notification settings - Fork 778
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Call writeDeployConfig
in writeBundle
rather than builder.buildApp
#8079
Conversation
🦋 Changeset detectedLatest commit: 4212d55 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
A wrangler prerelease is available for testing. You can install this latest build in your project with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13290765341/npm-package-wrangler-8079 You can reference the automatically updated head of this PR with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/8079/npm-package-wrangler-8079 Or you can use npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13290765341/npm-package-wrangler-8079 dev path/to/script.js Additional artifacts:cloudflare-workers-bindings-extension: wget https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13290765341/npm-package-cloudflare-workers-bindings-extension-8079 -O ./cloudflare-workers-bindings-extension.0.0.0-v83950fdfd.vsix && code --install-extension ./cloudflare-workers-bindings-extension.0.0.0-v83950fdfd.vsix create-cloudflare: npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13290765341/npm-package-create-cloudflare-8079 --no-auto-update @cloudflare/kv-asset-handler: npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13290765341/npm-package-cloudflare-kv-asset-handler-8079 miniflare: npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13290765341/npm-package-miniflare-8079 @cloudflare/pages-shared: npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13290765341/npm-package-cloudflare-pages-shared-8079 @cloudflare/unenv-preset: npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13290765341/npm-package-cloudflare-unenv-preset-8079 @cloudflare/vite-plugin: npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13290765341/npm-package-cloudflare-vite-plugin-8079 @cloudflare/vitest-pool-workers: npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13290765341/npm-package-cloudflare-vitest-pool-workers-8079 @cloudflare/workers-editor-shared: npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13290765341/npm-package-cloudflare-workers-editor-shared-8079 @cloudflare/workers-shared: npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13290765341/npm-package-cloudflare-workers-shared-8079 @cloudflare/workflows-shared: npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13290765341/npm-package-cloudflare-workflows-shared-8079 Note that these links will no longer work once the GitHub Actions artifact expires.
Please ensure constraints are pinned, and |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just simplified the logic in this file. Functionally it's the same.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice! 🫶
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice! 🫶
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agreeing with Dario generally but adding my approval on behalf of the wrangler team
72a1cea
to
4212d55
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for the updates 🙂
Fixes #000.
The deploy config file is now written in the
writeBundle
hook rather thanbuilder.buildApp
. This ensures that the file is still written if other plugins overridebuilder
in the Vite config.