Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Call writeDeployConfig in writeBundle rather than builder.buildApp #8079

Merged
merged 5 commits into from
Feb 12, 2025

Conversation

jamesopstad
Copy link
Contributor

Fixes #000.

The deploy config file is now written in the writeBundle hook rather than builder.buildApp. This ensures that the file is still written if other plugins override builder in the Vite config.


  • Tests
    • TODO (before merge)
    • Tests included: already covered by tests
    • Tests not necessary because:
  • E2E Tests CI Job required? (Use "e2e" label or ask maintainer to run separately)
    • I don't know
    • Required
    • Not required because: only affects Vite plugin
  • Public documentation
    • TODO (before merge)
    • Cloudflare docs PR(s):
    • Documentation not necessary because: internal change

@jamesopstad jamesopstad requested review from a team as code owners February 10, 2025 12:17
Copy link

changeset-bot bot commented Feb 10, 2025

🦋 Changeset detected

Latest commit: 4212d55

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@cloudflare/vite-plugin Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

github-actions bot commented Feb 10, 2025

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13290765341/npm-package-wrangler-8079

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/8079/npm-package-wrangler-8079

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13290765341/npm-package-wrangler-8079 dev path/to/script.js
Additional artifacts:

cloudflare-workers-bindings-extension:

wget https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13290765341/npm-package-cloudflare-workers-bindings-extension-8079 -O ./cloudflare-workers-bindings-extension.0.0.0-v83950fdfd.vsix && code --install-extension ./cloudflare-workers-bindings-extension.0.0.0-v83950fdfd.vsix

create-cloudflare:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13290765341/npm-package-create-cloudflare-8079 --no-auto-update

@cloudflare/kv-asset-handler:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13290765341/npm-package-cloudflare-kv-asset-handler-8079

miniflare:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13290765341/npm-package-miniflare-8079

@cloudflare/pages-shared:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13290765341/npm-package-cloudflare-pages-shared-8079

@cloudflare/unenv-preset:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13290765341/npm-package-cloudflare-unenv-preset-8079

@cloudflare/vite-plugin:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13290765341/npm-package-cloudflare-vite-plugin-8079

@cloudflare/vitest-pool-workers:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13290765341/npm-package-cloudflare-vitest-pool-workers-8079

@cloudflare/workers-editor-shared:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13290765341/npm-package-cloudflare-workers-editor-shared-8079

@cloudflare/workers-shared:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13290765341/npm-package-cloudflare-workers-shared-8079

@cloudflare/workflows-shared:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13290765341/npm-package-cloudflare-workflows-shared-8079

Note that these links will no longer work once the GitHub Actions artifact expires.


[email protected] includes the following runtime dependencies:

Package Constraint Resolved
miniflare workspace:* 3.20250204.0
workerd 1.20250204.0 1.20250204.0
workerd --version 1.20250204.0 2025-02-04

Please ensure constraints are pinned, and miniflare/workerd minor versions match.

@jamesopstad jamesopstad added the vite-plugin Relating to the `@cloudflare/vite-plugin` package label Feb 10, 2025
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just simplified the logic in this file. Functionally it's the same.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice! 🫶

.changeset/modern-cycles-build.md Show resolved Hide resolved
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice! 🫶

packages/vite-plugin-cloudflare/src/index.ts Show resolved Hide resolved
Copy link
Contributor

@petebacondarwin petebacondarwin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreeing with Dario generally but adding my approval on behalf of the wrangler team

@jamesopstad jamesopstad force-pushed the james/move-writeDeployConfig branch from 72a1cea to 4212d55 Compare February 12, 2025 17:01
Copy link
Member

@dario-piotrowicz dario-piotrowicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the updates 🙂

@jamesopstad jamesopstad merged commit 1b07419 into main Feb 12, 2025
18 checks passed
@jamesopstad jamesopstad deleted the james/move-writeDeployConfig branch February 12, 2025 17:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
vite-plugin Relating to the `@cloudflare/vite-plugin` package
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants