Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove debug ids from upload-sourcemaps.ts #8124

Merged
merged 1 commit into from
Feb 13, 2025

Conversation

WillTaylorDev
Copy link
Contributor

Debug IDs were causing a mismatch with expected release. Since we are creating our own release, we can remove this. Validated in staging:
https://docs.sentry.io/platforms/javascript/sourcemaps/troubleshooting_js/artifact-bundles/

  • Tests
    • TODO (before merge)
    • Tests included
    • Tests not necessary because: n/a
  • Wrangler E2E Tests CI Job required? (Use "e2e" label or ask maintainer to run separately)
    • I don't know
    • Required
    • Not required because: n/a
  • Public documentation
    • TODO (before merge)
    • Cloudflare docs PR(s):
    • Documentation not necessary because: n/a

Copy link

changeset-bot bot commented Feb 13, 2025

⚠️ No Changeset found

Latest commit: 238f0b4

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13298542173/npm-package-wrangler-8124

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/8124/npm-package-wrangler-8124

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13298542173/npm-package-wrangler-8124 dev path/to/script.js
Additional artifacts:

cloudflare-workers-bindings-extension:

wget https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13298542173/npm-package-cloudflare-workers-bindings-extension-8124 -O ./cloudflare-workers-bindings-extension.0.0.0-v8152419e6.vsix && code --install-extension ./cloudflare-workers-bindings-extension.0.0.0-v8152419e6.vsix

create-cloudflare:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13298542173/npm-package-create-cloudflare-8124 --no-auto-update

@cloudflare/kv-asset-handler:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13298542173/npm-package-cloudflare-kv-asset-handler-8124

miniflare:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13298542173/npm-package-miniflare-8124

@cloudflare/pages-shared:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13298542173/npm-package-cloudflare-pages-shared-8124

@cloudflare/unenv-preset:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13298542173/npm-package-cloudflare-unenv-preset-8124

@cloudflare/vite-plugin:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13298542173/npm-package-cloudflare-vite-plugin-8124

@cloudflare/vitest-pool-workers:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13298542173/npm-package-cloudflare-vitest-pool-workers-8124

@cloudflare/workers-editor-shared:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13298542173/npm-package-cloudflare-workers-editor-shared-8124

@cloudflare/workers-shared:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13298542173/npm-package-cloudflare-workers-shared-8124

@cloudflare/workflows-shared:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13298542173/npm-package-cloudflare-workflows-shared-8124

Note that these links will no longer work once the GitHub Actions artifact expires.


[email protected] includes the following runtime dependencies:

Package Constraint Resolved
miniflare workspace:* 3.20250204.0
workerd 1.20250204.0 1.20250204.0
workerd --version 1.20250204.0 2025-02-04

Please ensure constraints are pinned, and miniflare/workerd minor versions match.

@WillTaylorDev WillTaylorDev merged commit ddaef2b into main Feb 13, 2025
32 of 33 checks passed
@WillTaylorDev WillTaylorDev deleted the willtaylor/sourcemap-upload-fix branch February 13, 2025 01:48
sdnts pushed a commit to sdnts/workers-sdk that referenced this pull request Feb 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants