Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add status code analytics to router-worker #8126

Merged
merged 1 commit into from
Feb 13, 2025

Conversation

GregBrimble
Copy link
Contributor

WC-3202

The cost of an await here is outweighed by the confidence we get in making stable asset-worker releases.


  • Tests
    • TODO (before merge)
    • Tests included
    • Tests not necessary because: no coverage
  • Wrangler E2E Tests CI Job required? (Use "e2e" label or ask maintainer to run separately)
    • I don't know
    • Required
    • Not required because: no coverage
  • Public documentation
    • TODO (before merge)
    • Cloudflare docs PR(s):
    • Documentation not necessary because: internal change

@GregBrimble GregBrimble requested review from a team as code owners February 13, 2025 03:33
Copy link

changeset-bot bot commented Feb 13, 2025

🦋 Changeset detected

Latest commit: c1968ec

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@cloudflare/workers-shared Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13299873154/npm-package-wrangler-8126

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/8126/npm-package-wrangler-8126

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13299873154/npm-package-wrangler-8126 dev path/to/script.js
Additional artifacts:

cloudflare-workers-bindings-extension:

wget https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13299873154/npm-package-cloudflare-workers-bindings-extension-8126 -O ./cloudflare-workers-bindings-extension.0.0.0-vfb8443595.vsix && code --install-extension ./cloudflare-workers-bindings-extension.0.0.0-vfb8443595.vsix

create-cloudflare:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13299873154/npm-package-create-cloudflare-8126 --no-auto-update

@cloudflare/kv-asset-handler:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13299873154/npm-package-cloudflare-kv-asset-handler-8126

miniflare:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13299873154/npm-package-miniflare-8126

@cloudflare/pages-shared:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13299873154/npm-package-cloudflare-pages-shared-8126

@cloudflare/unenv-preset:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13299873154/npm-package-cloudflare-unenv-preset-8126

@cloudflare/vite-plugin:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13299873154/npm-package-cloudflare-vite-plugin-8126

@cloudflare/vitest-pool-workers:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13299873154/npm-package-cloudflare-vitest-pool-workers-8126

@cloudflare/workers-editor-shared:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13299873154/npm-package-cloudflare-workers-editor-shared-8126

@cloudflare/workers-shared:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13299873154/npm-package-cloudflare-workers-shared-8126

@cloudflare/workflows-shared:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13299873154/npm-package-cloudflare-workflows-shared-8126

Note that these links will no longer work once the GitHub Actions artifact expires.


[email protected] includes the following runtime dependencies:

Package Constraint Resolved
miniflare workspace:* 3.20250204.0
workerd 1.20250204.0 1.20250204.0
workerd --version 1.20250204.0 2025-02-04

Please ensure constraints are pinned, and miniflare/workerd minor versions match.

@GregBrimble GregBrimble requested a review from Copilot February 13, 2025 04:48

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

@penalosa penalosa merged commit 59eda4a into main Feb 13, 2025
27 checks passed
@penalosa penalosa deleted the add-status-code-analytics-to-asset-worker branch February 13, 2025 12:51
sdnts pushed a commit to sdnts/workers-sdk that referenced this pull request Feb 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants