Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(create-cloudflare): make DNS poling copy more user friendly #8215

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

CarmenPopoviciu
Copy link
Contributor

@CarmenPopoviciu CarmenPopoviciu commented Feb 21, 2025

This change makes the user facing message C3 displays while waiting for DNS propagation, more friendly/informative. The idea is to inform users that DNS propagation might sometimes take even up to 2 minutes. This will hopefully prevent confusion around whether how long the process will take, or whether the process is stuck, etc.

See #8187


  • Tests
    • TODO (before merge)
    • Tests included
    • Tests not necessary because: just copy change. Also the fn that contains this message is not covered by tests
  • Wrangler E2E Tests CI Job required? (Use "e2e" label or ask maintainer to run separately)
    • I don't know
    • Required
    • Not required because: just copy change
  • Public documentation
    • TODO (before merge)
    • Cloudflare docs PR(s):
    • Documentation not necessary because: just copy change

@CarmenPopoviciu CarmenPopoviciu requested review from a team as code owners February 21, 2025 13:57
Copy link

changeset-bot bot commented Feb 21, 2025

🦋 Changeset detected

Latest commit: 41c8e89

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
create-cloudflare Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

github-actions bot commented Feb 21, 2025

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13458416649/npm-package-wrangler-8215

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/8215/npm-package-wrangler-8215

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13458416649/npm-package-wrangler-8215 dev path/to/script.js
Additional artifacts:

cloudflare-workers-bindings-extension:

wget https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13458416649/npm-package-cloudflare-workers-bindings-extension-8215 -O ./cloudflare-workers-bindings-extension.0.0.0-v013a076b9.vsix && code --install-extension ./cloudflare-workers-bindings-extension.0.0.0-v013a076b9.vsix

create-cloudflare:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13458416649/npm-package-create-cloudflare-8215 --no-auto-update

@cloudflare/kv-asset-handler:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13458416649/npm-package-cloudflare-kv-asset-handler-8215

miniflare:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13458416649/npm-package-miniflare-8215

@cloudflare/pages-shared:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13458416649/npm-package-cloudflare-pages-shared-8215

@cloudflare/unenv-preset:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13458416649/npm-package-cloudflare-unenv-preset-8215

@cloudflare/vite-plugin:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13458416649/npm-package-cloudflare-vite-plugin-8215

@cloudflare/vitest-pool-workers:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13458416649/npm-package-cloudflare-vitest-pool-workers-8215

@cloudflare/workers-editor-shared:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13458416649/npm-package-cloudflare-workers-editor-shared-8215

@cloudflare/workers-shared:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13458416649/npm-package-cloudflare-workers-shared-8215

@cloudflare/workflows-shared:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13458416649/npm-package-cloudflare-workflows-shared-8215

Note that these links will no longer work once the GitHub Actions artifact expires.


[email protected] includes the following runtime dependencies:

Package Constraint Resolved
miniflare workspace:* 3.20250214.0
workerd 1.20250214.0 1.20250214.0
workerd --version 1.20250214.0 2025-02-14

Please ensure constraints are pinned, and miniflare/workerd minor versions match.

@@ -22,7 +22,7 @@ export const poll = async (url: string): Promise<boolean> => {
const domain = new URL(url).host;
const s = spinner();

s.start("Waiting for DNS to propagate");
s.start("Waiting for DNS to propagate. This might take up to two minutes.");
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this will be mostly true for Pages but I'm not sure if it's worth calling that out. IMHO it'll just make the copy more noisy

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Untriaged
Development

Successfully merging this pull request may close these issues.

2 participants