-
Notifications
You must be signed in to change notification settings - Fork 787
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(create-cloudflare): make DNS poling copy more user friendly #8215
base: main
Are you sure you want to change the base?
Conversation
🦋 Changeset detectedLatest commit: 41c8e89 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
A wrangler prerelease is available for testing. You can install this latest build in your project with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13458416649/npm-package-wrangler-8215 You can reference the automatically updated head of this PR with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/8215/npm-package-wrangler-8215 Or you can use npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13458416649/npm-package-wrangler-8215 dev path/to/script.js Additional artifacts:cloudflare-workers-bindings-extension: wget https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13458416649/npm-package-cloudflare-workers-bindings-extension-8215 -O ./cloudflare-workers-bindings-extension.0.0.0-v013a076b9.vsix && code --install-extension ./cloudflare-workers-bindings-extension.0.0.0-v013a076b9.vsix create-cloudflare: npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13458416649/npm-package-create-cloudflare-8215 --no-auto-update @cloudflare/kv-asset-handler: npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13458416649/npm-package-cloudflare-kv-asset-handler-8215 miniflare: npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13458416649/npm-package-miniflare-8215 @cloudflare/pages-shared: npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13458416649/npm-package-cloudflare-pages-shared-8215 @cloudflare/unenv-preset: npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13458416649/npm-package-cloudflare-unenv-preset-8215 @cloudflare/vite-plugin: npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13458416649/npm-package-cloudflare-vite-plugin-8215 @cloudflare/vitest-pool-workers: npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13458416649/npm-package-cloudflare-vitest-pool-workers-8215 @cloudflare/workers-editor-shared: npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13458416649/npm-package-cloudflare-workers-editor-shared-8215 @cloudflare/workers-shared: npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13458416649/npm-package-cloudflare-workers-shared-8215 @cloudflare/workflows-shared: npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13458416649/npm-package-cloudflare-workflows-shared-8215 Note that these links will no longer work once the GitHub Actions artifact expires.
Please ensure constraints are pinned, and |
a5eaa43
to
41c8e89
Compare
@@ -22,7 +22,7 @@ export const poll = async (url: string): Promise<boolean> => { | |||
const domain = new URL(url).host; | |||
const s = spinner(); | |||
|
|||
s.start("Waiting for DNS to propagate"); | |||
s.start("Waiting for DNS to propagate. This might take up to two minutes."); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this will be mostly true for Pages but I'm not sure if it's worth calling that out. IMHO it'll just make the copy more noisy
This change makes the user facing message C3 displays while waiting for DNS propagation, more friendly/informative. The idea is to inform users that DNS propagation might sometimes take even up to 2 minutes. This will hopefully prevent confusion around whether how long the process will take, or whether the process is stuck, etc.
See #8187