Skip to content
This repository has been archived by the owner on Jul 28, 2020. It is now read-only.

Commit

Permalink
Bump v4 -> v5 in metadata requirements
Browse files Browse the repository at this point in the history
  • Loading branch information
Anthony Emengo committed Apr 4, 2019
1 parent 691a55a commit dc2e061
Show file tree
Hide file tree
Showing 5 changed files with 9 additions and 9 deletions.
2 changes: 1 addition & 1 deletion cmd/deploy-service/deploy_service.go
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ type Analytics interface {
Event(event string, data ...map[string]interface{}) error
}

const compatibilityVersion = "v4"
const compatibilityVersion = "v5"

type DeployService struct {
Exit chan struct{}
Expand Down
6 changes: 3 additions & 3 deletions cmd/deploy-service/deploy_service_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ var _ = Describe("DeployService", func() {
Name: "some-service",
}
mockMetadataReader.EXPECT().Metadata().Return(workspace.Metadata{
Version: "v4",
Version: "v5",
Services: []workspace.Service{service},
}, nil)

Expand All @@ -69,7 +69,7 @@ var _ = Describe("DeployService", func() {
Name: "some-service",
}
mockMetadataReader.EXPECT().Metadata().Return(workspace.Metadata{
Version: "v4",
Version: "v5",
Services: []workspace.Service{service},
}, nil)
mockProvisioner.EXPECT().Ping(gomock.Any()).Return(errors.New("some issue happened"))
Expand All @@ -88,7 +88,7 @@ var _ = Describe("DeployService", func() {
Name: "some-service",
}
mockMetadataReader.EXPECT().Metadata().Return(workspace.Metadata{
Version: "v4",
Version: "v5",
Services: []workspace.Service{service},
}, nil)
mockProvisioner.EXPECT().Ping(gomock.Any()).Return(nil)
Expand Down
2 changes: 1 addition & 1 deletion cmd/provision/provision.go
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ type Provisioner interface {
DeployServices(provision.UI, []workspace.Service, []string) error
}

const compatibilityVersion = "v4"
const compatibilityVersion = "v5"

type Provision struct {
Exit chan struct{}
Expand Down
6 changes: 3 additions & 3 deletions cmd/provision/provision_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ var _ = Describe("Provision", func() {
It("deploys bosh and services", func() {
gomock.InOrder(
mockMetadataReader.EXPECT().Metadata().Return(workspace.Metadata{
Version: "v4",
Version: "v5",
}, nil),
mockProvisioner.EXPECT().Ping(gomock.Any()),
mockUI.EXPECT().Say("Deploying the BOSH Director..."),
Expand Down Expand Up @@ -75,7 +75,7 @@ var _ = Describe("Provision", func() {
It("pass them to services", func() {
gomock.InOrder(
mockMetadataReader.EXPECT().Metadata().Return(workspace.Metadata{
Version: "v4",
Version: "v5",
}, nil),
mockProvisioner.EXPECT().Ping(gomock.Any()),
mockUI.EXPECT().Say("Deploying the BOSH Director..."),
Expand All @@ -95,7 +95,7 @@ var _ = Describe("Provision", func() {
It("return an error", func() {
gomock.InOrder(
mockMetadataReader.EXPECT().Metadata().Return(workspace.Metadata{
Version: "v4",
Version: "v5",
}, nil),
mockProvisioner.EXPECT().Ping(gomock.Any()).Return(errors.New("not running")),
)
Expand Down
2 changes: 1 addition & 1 deletion cmd/start/start.go
Original file line number Diff line number Diff line change
Expand Up @@ -105,7 +105,7 @@ type Start struct {
}

const (
compatibilityVersion = "v4"
compatibilityVersion = "v5"
defaultMemory = 4192
)

Expand Down

0 comments on commit dc2e061

Please sign in to comment.