-
Notifications
You must be signed in to change notification settings - Fork 173
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
wip: test: add test for loadbalancing route option #1424
Draft
maxmoehl
wants to merge
19
commits into
cloudfoundry:develop
Choose a base branch
from
sap-contributions:maxmoehl/add-route-options
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
wip: test: add test for loadbalancing route option #1424
maxmoehl
wants to merge
19
commits into
cloudfoundry:develop
from
sap-contributions:maxmoehl/add-route-options
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hoffmaen
force-pushed
the
maxmoehl/add-route-options
branch
from
January 28, 2025 18:55
9e76848
to
2474f7a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Are you submitting this PR against the develop branch?
All PR's to CATs should be submitted to develop and will be merged to main once they've passed acceptance.
What is this change about?
Add an acceptance test for per-route options as described in #1352.
Please provide contextual information.
#1352, cloudfoundry/community#909
What version of cf-deployment have you run this cf-acceptance-test change against?
Please check all that apply for this PR:
Did you update the README as appropriate for this change?
If you are introducing a new acceptance test, what is your rationale for including it CATs rather than your own acceptance test suite?
It tests the E2E functionality of per-route options. Each component has its own acceptance tests but we want to ensure that the E2E scenario works with every released cf-d.
How many more (or fewer) seconds of runtime will this change introduce to CATs?
Unknown
What is the level of urgency for publishing this change?
Tag your pair, your PM, and/or team!