Remove experimental ops file disable-v2-api #1230
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jochenehret
requested changes
Feb 10, 2025
operations/experimental/README.md
Outdated
| @@ -11,43 +11,43 @@ This is the README for Experimental Ops-files. To learn more about `cf-deploymen | |||
|
|
|||
| # Experimental ops files | |||
|
|
|||
| | Name | Purpose | Notes | Currently validated in Release Integration CI pipelines? | | |||
There was a problem hiding this comment.
Have you opened the Markdown file in IntelliJ? It reformats the whole file which makes diffs hard to detect. Better open it in a plain text editor.
There was a problem hiding this comment.
I managed to adjust the file in sublime and the diff looks much better now.
dimivel
force-pushed
the
remove-disable-v2-api
branch
from
c02c767 to
d215070
Compare
jochenehret
previously approved these changes
Feb 12, 2025
| @@ -23,10 +23,6 @@ disable-logs-in-firehose.yml: {} | |||
| disable-logs-in-firehose-windows2019.yml: | |||
| ops: | |||
| - ../windows2019-cell.yml | |||
| disable-v2-api.yml: | |||
There was a problem hiding this comment.
I think we still need this unit test. There's a check in place that ensures that all ops files have a test, even if the ops file just consists of comments.
|
It's also not a breaking change as the ops file is not removed, can you please adapt the description? |
|
Hello friend, it looks like your pull request has failed one or more of our checks. Please take a look! 👀 |
dimivel
force-pushed
the
remove-disable-v2-api
branch
from
d215070 to
fe4e918
Compare
jochenehret
approved these changes
Feb 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHAT is this change about?
API v2 is disabled by default, see cloudfoundry/capi-release#503 and RFC0032 - CF API v2 End of Life
Please provide any contextual information.
Since API v2 is disabled by default there is no need of experimental ops file disable-v2-api.
Has a cf-deployment including this change passed cf-acceptance-tests?
Does this PR introduce a breaking change? Please take a moment to read through the examples before answering the question.
Does this PR introduce a new BOSH release into the base cf-deployment.yml manifest or any ops-files?
Does this PR make a change to an experimental or GA'd feature/component?
Please provide Acceptance Criteria for this change?
What is the level of urgency for publishing this change?
Tag your pair, your PM, and/or team!