Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SurgicalPool extension by the load balancing algorithm (the same way as the RoutePool) #457

Closed
wants to merge 17 commits into from
Closed

SurgicalPool extension by the load balancing algorithm (the same way as the RoutePool) #457

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
c15444f
Surgical pool needs LB Algo
Dariquest Dec 12, 2024
d814eff
Extend logging
Dariquest Dec 13, 2024
2632ed4
Extend logging by pool host
Dariquest Dec 16, 2024
0f0b30e
Improve logging
Dariquest Dec 16, 2024
96006aa
Rollback
Dariquest Dec 17, 2024
20e5192
feat: make syslog logging useable
maxmoehl Apr 19, 2024
d307339
fix: allow syslog-only logging
maxmoehl Apr 25, 2024
a3dfdcc
feat: replace log/syslog with internal version
maxmoehl Nov 20, 2024
5d47ba3
fix: rename testState.newRequest -> testState.newGetRequest
maxmoehl Dec 9, 2024
8e2de15
test: add integration test for syslog access logs
maxmoehl Dec 9, 2024
9f4ef4e
Revert "test: add integration test for syslog access logs"
ameowlia Dec 13, 2024
1f1b788
Revert "fix: rename testState.newRequest -> testState.newGetRequest"
ameowlia Dec 13, 2024
120c710
Revert "feat: replace log/syslog with internal version"
ameowlia Dec 13, 2024
7c93738
Revert "fix: allow syslog-only logging"
ameowlia Dec 13, 2024
9a623b1
Revert "feat: make syslog logging useable"
ameowlia Dec 13, 2024
f55a369
Syslog Improvements (2) (#459)
maxmoehl Dec 16, 2024
0b7a36c
Extend logging by Path
Dariquest Dec 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 6 additions & 5 deletions registry/registry.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -262,11 +262,12 @@ func (r *RouteRegistry) LookupWithInstance(uri route.Uri, appID string, appIndex
p.Each(func(e *route.Endpoint) {
if (e.ApplicationId == appID) && (e.PrivateInstanceIndex == appIndex) {
surgicalPool = route.NewPool(&route.PoolOpts{
Logger: r.logger,
RetryAfterFailure: 0,
Host: p.Host(),
ContextPath: p.ContextPath(),
MaxConnsPerBackend: p.MaxConnsPerBackend(),
Logger: r.logger,
RetryAfterFailure: 0,
Host: p.Host(),
ContextPath: p.ContextPath(),
MaxConnsPerBackend: p.MaxConnsPerBackend(),
LoadBalancingAlgorithm: p.LoadBalancingAlgorithm,
})
surgicalPool.Put(e)
}
Expand Down
4 changes: 3 additions & 1 deletion route/pool.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -384,7 +384,9 @@ func (p *EndpointPool) Endpoints(logger *slog.Logger, initial string, mustBeStic
logger.Debug("endpoint-iterator-with-round-robin-lb-algo")
return NewRoundRobin(logger, p, initial, mustBeSticky, azPreference == config.AZ_PREF_LOCAL, az)
default:
logger.Error("invalid-pool-load-balancing-algorithm", slog.String("poolLBAlgorithm", p.LoadBalancingAlgorithm))
logger.Error("invalid-pool-load-balancing-algorithm",
slog.String("poolLBAlgorithm", p.LoadBalancingAlgorithm),
slog.Group("data", slog.String("Host", p.host)))
Dariquest marked this conversation as resolved.
Show resolved Hide resolved
return NewRoundRobin(logger, p, initial, mustBeSticky, azPreference == config.AZ_PREF_LOCAL, az)
}
}
Expand Down