Skip to content

Commit

Permalink
Refactor kpack-image-builder tests
Browse files Browse the repository at this point in the history
The builder info is created in `JustBeforeEach` so that the test could
conifugure its finalizers in `BeforeEach`. This is to address a flake in
the test when the builder info is being deleted, e.g
https://ci.korifi.cf-app.com/teams/main/pipelines/main/jobs/run-tests-periodic/builds/21592

While being here,
- refactor the suite to create the test root namespace and start the controller in `BeforeEach`. Thus test could not bother cleaning up.
- remove`Serial` from the builder info controller test
- Simplify the builder info controller test by removing contexts that do
  not contribute changes to the default setup
- Remove test cases that verify that the builder info controller is
  listening on cluster builder eventually deletion. The test verifies
  that the info is reconciled on builder change, no need to check the
  same on cluster builder delete (as from controller's point of view,
  the change type does not really matter)

issue #3743
  • Loading branch information
danail-branekov authored and georgethebeatle committed Jan 27, 2025
1 parent 0ce20a1 commit 66c2c66
Show file tree
Hide file tree
Showing 4 changed files with 246 additions and 380 deletions.
Loading

0 comments on commit 66c2c66

Please sign in to comment.