Unpin CF cli

[danail-branekov]

Is there a related GitHub Issue?

#3649

What is this change about?

• Revert "Temporarily pin cf cli version to 8.8.3"
• Enable globstar option when running bash commands

Does this PR introduce a breaking change?

No

Tag your pair, your PM, and/or team

@georgethebeatle @uzabanov

[cniles]

@georgethebeatle @danail-branekov, a thought on the setting use of the globstar option. This breaks compatability with versions of bash older than 4.0. MacOS doesn't come bundled with bash 4.0 for licensing reasons. Its simple enough to alter/disable it or even install bash 4.0 through homebrew, but thats a minor irritance. Maybe its worth considering an alternative that doesn't use the globstar feature? It looks like the only line that uses it is to clean; an alternative maybe find ./ -d -name bin -exec rm -rf {} \; ?

[danail-branekov]

Fair point @cniles

Do you know whether Korifi's Makefile is compatible with older bash versions? If not, we should maybe not bother about it. And I really would not want to downgrade my dev setup to test it.

We use recent bash versions (bash 4 has been released sixteen years ago!) and we do not consider supporting such old versions. But if that is a low-hanging fruit, we could totally do that.

[cniles]

Thanks for the response. All the make targets work. I feel slightly silly for bringing it up now and take your point of how old it is 😳, but I do think it could potentially make the local dev setup process less abrasive.

This command appears to have an equivalent effect of removing all the binaries while preserving bin directories:

find . -wholename '*/bin/*' -delete

[danail-branekov]

It is a bit funny that today a colleague of mine complained that make does not work on his mac anymore :)

Would you be willing to PR a change with the command you pointed out - you would get some contributions credits! I would only request to put a comment on the command why globs are not used - we would probably "fix" it several months later after we have forgotten about this conversation :)