Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(helm): add OpenSearch Operator Helm chart #513

Open
wants to merge 27 commits into
base: main
Choose a base branch
from

Conversation

joluc
Copy link

@joluc joluc commented Nov 18, 2024

Pull Request Details

Provide details about your pull request and what it adds, fixes, or changes.

This PR adds a Helm chart for the OpenSearch Operator

@joluc joluc marked this pull request as ready for review February 20, 2025 14:32
@joluc joluc requested review from a team as code owners February 20, 2025 14:32
Copy link
Member

@timojohlo timojohlo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for putting work into this and cool to see the progress!
I have added some comments, let me know if you have questions :)

@@ -15,6 +15,7 @@ on:
- kubeconfig-generator/chart/**
- logshipper/chart/**
- obenbao/charts/**
- opensearch/chart/**
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can do the same for the workflow/ci-pr-build.yaml to benefit from testing charts already during an open PR


## Architecture

![OpenSearch Architecture](img/opensearch-arch.png)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the README so far. Your plan here was to come up with the architecture image/draw.io at a later stage, but maybe you can add it already?

dependencies:
- name: opensearch-operator
alias: opensearchOperator
repository: https://opensearch-project.github.io/opensearch-k8s-operator/ # TODO: Move to -> oci://ghcr.io/cloudoperators/greenhouse-extensions/charts
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As I understand it you will use the upstream charts? Then this will likely stay and will have the depedency from there, no?

version: 2.7.0
- name: opensearch-cluster
alias: opensearchCluster
repository: https://opensearch-project.github.io/opensearch-k8s-operator/ # TODO: Move to -> oci://ghcr.io/cloudoperators/greenhouse-extensions/charts
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there another helm-chart used for the clusters? Then this repository likely needs to point to that one.

Comment on lines +10 to +11
password: YWRtaW4= # admin (testing only)
username: YWRtaW4= # admin (testing only)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

security-wise and going forward I think it makes sense to template the secrets here and add them as a field in the plugindefinition?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants