-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(renovate): bump kube-monitoring & alerts plugindefinition #668
base: main
Are you sure you want to change the base?
fix(renovate): bump kube-monitoring & alerts plugindefinition #668
Conversation
Signed-off-by: Richard Tief <[email protected]>
for this to work, you need to create tags for kube-monitoring and alerts in the repo. Sadly the packages are not enough to be released. I need to check if the |
Ok. Could you please point me to where I need to put the tags. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I made some changes, this should work.
Please also check this commit: d241291
The above added line is crucial for renovate to know where to look for.
"matchStrings": [ | ||
"helmChart:\\s*name:\\s*.*\\s*repository:\\s*.*\\s*version\\s*\\:\\s*(?<currentValue>v?(?:\\d+\\.){0,2}\\d+)" | ||
], | ||
"datasourceTemplate": "github-tags", | ||
"depNameTemplate": "greenhouse-extensions/charts/kube-monitoring", | ||
"extractVersionTemplate": "^(?<version>.*)$" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"matchStrings": [ | |
"helmChart:\\s*name:\\s*.*\\s*repository:\\s*.*\\s*version\\s*\\:\\s*(?<currentValue>v?(?:\\d+\\.){0,2}\\d+)" | |
], | |
"datasourceTemplate": "github-tags", | |
"depNameTemplate": "greenhouse-extensions/charts/kube-monitoring", | |
"extractVersionTemplate": "^(?<version>.*)$" | |
"matchStrings": [ | |
"# renovate depName=(?<packageName>.*)\\s*name:\\s*.*\\s*repository:\\s*.*\\s*version\\s*\\:\\s*(?<currentValue>v?(?:\\d+\\.){0,2}\\d+)" | |
], | |
"datasourceTemplate": "docker", | |
"versioningTemplate": "helm" |
"matchStrings": [ | ||
"helmChart:\\s*name:\\s*.*\\s*repository:\\s*.*\\s*version\\s*\\:\\s*(?<currentValue>v?(?:\\d+\\.){0,2}\\d+)" | ||
], | ||
"datasourceTemplate": "github-tags", | ||
"depNameTemplate": "greenhouse-extensions/charts/alerts", | ||
"extractVersionTemplate": "^(?<version>.*)$" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"matchStrings": [ | |
"helmChart:\\s*name:\\s*.*\\s*repository:\\s*.*\\s*version\\s*\\:\\s*(?<currentValue>v?(?:\\d+\\.){0,2}\\d+)" | |
], | |
"datasourceTemplate": "github-tags", | |
"depNameTemplate": "greenhouse-extensions/charts/alerts", | |
"extractVersionTemplate": "^(?<version>.*)$" | |
"matchStrings": [ | |
"# renovate depName=(?<packageName>.*)\\s*name:\\s*.*\\s*repository:\\s*.*\\s*version\\s*\\:\\s*(?<currentValue>v?(?:\\d+\\.){0,2}\\d+)" | |
], | |
"datasourceTemplate": "docker", | |
"versioningTemplate": "helm" |
@kengou Please review if this change makes sense.