Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(renovate): bump kube-monitoring & alerts plugindefinition #668

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

richardtief
Copy link
Member

@kengou Please review if this change makes sense.

@richardtief richardtief requested a review from a team as a code owner February 21, 2025 13:59
@kengou
Copy link
Contributor

kengou commented Feb 21, 2025

for this to work, you need to create tags for kube-monitoring and alerts in the repo. Sadly the packages are not enough to be released. I need to check if the datasourceTemplate: docker is working with helm or not

@richardtief
Copy link
Member Author

richardtief commented Feb 21, 2025

Ok. Could you please point me to where I need to put the tags.

@kengou kengou requested a review from a team as a code owner February 22, 2025 01:17
Copy link
Contributor

@kengou kengou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I made some changes, this should work.
Please also check this commit: d241291
The above added line is crucial for renovate to know where to look for.

Comment on lines +53 to +58
"matchStrings": [
"helmChart:\\s*name:\\s*.*\\s*repository:\\s*.*\\s*version\\s*\\:\\s*(?<currentValue>v?(?:\\d+\\.){0,2}\\d+)"
],
"datasourceTemplate": "github-tags",
"depNameTemplate": "greenhouse-extensions/charts/kube-monitoring",
"extractVersionTemplate": "^(?<version>.*)$"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"matchStrings": [
"helmChart:\\s*name:\\s*.*\\s*repository:\\s*.*\\s*version\\s*\\:\\s*(?<currentValue>v?(?:\\d+\\.){0,2}\\d+)"
],
"datasourceTemplate": "github-tags",
"depNameTemplate": "greenhouse-extensions/charts/kube-monitoring",
"extractVersionTemplate": "^(?<version>.*)$"
"matchStrings": [
"# renovate depName=(?<packageName>.*)\\s*name:\\s*.*\\s*repository:\\s*.*\\s*version\\s*\\:\\s*(?<currentValue>v?(?:\\d+\\.){0,2}\\d+)"
],
"datasourceTemplate": "docker",
"versioningTemplate": "helm"

Comment on lines +66 to +71
"matchStrings": [
"helmChart:\\s*name:\\s*.*\\s*repository:\\s*.*\\s*version\\s*\\:\\s*(?<currentValue>v?(?:\\d+\\.){0,2}\\d+)"
],
"datasourceTemplate": "github-tags",
"depNameTemplate": "greenhouse-extensions/charts/alerts",
"extractVersionTemplate": "^(?<version>.*)$"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"matchStrings": [
"helmChart:\\s*name:\\s*.*\\s*repository:\\s*.*\\s*version\\s*\\:\\s*(?<currentValue>v?(?:\\d+\\.){0,2}\\d+)"
],
"datasourceTemplate": "github-tags",
"depNameTemplate": "greenhouse-extensions/charts/alerts",
"extractVersionTemplate": "^(?<version>.*)$"
"matchStrings": [
"# renovate depName=(?<packageName>.*)\\s*name:\\s*.*\\s*repository:\\s*.*\\s*version\\s*\\:\\s*(?<currentValue>v?(?:\\d+\\.){0,2}\\d+)"
],
"datasourceTemplate": "docker",
"versioningTemplate": "helm"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants