-
Notifications
You must be signed in to change notification settings - Fork 6
Add a required variable #8
base: master
Are you sure you want to change the base?
Conversation
Since we are not required to create a separate chart repository in each account. Leaving it up to team's configuration. Several teams want to reuse the same charts, atleast infra charts.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry @rverma-nikiai ! Let this one fall through the cracks.
Let's stick to "true"
and "false"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rebuild README
outputs.tf
Outdated
@@ -1,15 +1,15 @@ | |||
output "bucket_domain_name" { | |||
value = "${aws_s3_bucket.default.bucket_domain_name}" | |||
value = "${aws_s3_bucket.default.*.bucket_domain_name}" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
let's use splat+join
pattern here since this is a list now aws_s3_bucket.default.*.bucket_domain_name
.
"${join("", aws_s3_bucket.default.*.bucket_domain_name)}"
although aws_s3_bucket.default.*.bucket_domain_name
(without join
) will work in many cases, in some more complex configuration it will break.
outputs.tf
Outdated
description = "S3 bucket domain name" | ||
} | ||
|
||
output "bucket_id" { | ||
value = "${aws_s3_bucket.default.id}" | ||
value = "${aws_s3_bucket.default.*.id}" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
let's use splat+join
pattern
outputs.tf
Outdated
description = "S3 bucket ID" | ||
} | ||
|
||
output "bucket_arn" { | ||
value = "${aws_s3_bucket.default.arn}" | ||
value = "${aws_s3_bucket.default.*.arn}" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
let's use splat+join
pattern here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
see comments
thanks @rverma-nikiai
Co-Authored-By: rverma-nikiai <[email protected]>
Co-Authored-By: rverma-nikiai <[email protected]>
Since we are not required to create a separate chart repository in each account. Leaving it up to team's configuration. Several teams want to reuse the same charts, atleast infra charts.