Skip to content
This repository has been archived by the owner on Jan 30, 2021. It is now read-only.

Add a required variable #8

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Add a required variable #8

wants to merge 6 commits into from

Conversation

rverma-nikiai
Copy link

Since we are not required to create a separate chart repository in each account. Leaving it up to team's configuration. Several teams want to reuse the same charts, atleast infra charts.

Since we are not required to create a separate chart repository in each account. Leaving it up to team's configuration. Several teams want to reuse the same charts, atleast infra charts.
@osterman osterman requested a review from aknysh December 6, 2018 06:31
main.tf Outdated Show resolved Hide resolved
variables.tf Outdated Show resolved Hide resolved
Copy link
Contributor

@osterman osterman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry @rverma-nikiai ! Let this one fall through the cracks.

Let's stick to "true" and "false"

Copy link
Contributor

@osterman osterman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rebuild README

outputs.tf Outdated
@@ -1,15 +1,15 @@
output "bucket_domain_name" {
value = "${aws_s3_bucket.default.bucket_domain_name}"
value = "${aws_s3_bucket.default.*.bucket_domain_name}"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's use splat+join pattern here since this is a list now aws_s3_bucket.default.*.bucket_domain_name.

"${join("", aws_s3_bucket.default.*.bucket_domain_name)}"

although aws_s3_bucket.default.*.bucket_domain_name (without join) will work in many cases, in some more complex configuration it will break.

outputs.tf Outdated
description = "S3 bucket domain name"
}

output "bucket_id" {
value = "${aws_s3_bucket.default.id}"
value = "${aws_s3_bucket.default.*.id}"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's use splat+join pattern

outputs.tf Outdated
description = "S3 bucket ID"
}

output "bucket_arn" {
value = "${aws_s3_bucket.default.arn}"
value = "${aws_s3_bucket.default.*.arn}"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's use splat+join pattern here

Copy link
Contributor

@aknysh aknysh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see comments
thanks @rverma-nikiai

osterman and others added 3 commits December 6, 2018 22:08
Co-Authored-By: rverma-nikiai <[email protected]>
Co-Authored-By: rverma-nikiai <[email protected]>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants