Install stubs for tools missing arm64 support #841
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
osterman
reviewed
Apr 3, 2023
| @@ -0,0 +1,4 @@ | |||
| #!/bin/bash | |||
|
|
|||
| printf "$(tput setaf 1)%s is not supported on this platform (arm64)$(tput setaf 0)\n" "$(basename "$0")" >&2 | |||
osterman
reviewed
Apr 3, 2023
Comment on lines
+1
to
+9
| # These are packages that are only supported on amd64, | ||
| # typically because they have not been updated since 2021. | ||
| awless@cloudposse | ||
| cfssl@cloudposse | ||
| emailcli@cloudposse | ||
| goofys@cloudposse | ||
| rakkess@cloudposse | ||
| tfenv@cloudposse | ||
| tfmask@cloudposse |
There was a problem hiding this comment.
I do believe we should deprecate 💯 of these from our base image. We can do that in a follow on PR. None of these are critical to have in the base image, and it's easy enough for users to mitigate it in their downstream images. Since 2.x has many breaking changes, this would be the time, no?
There was a problem hiding this comment.
@osterman The difficult one to remove is goofys, because we have commands s3 and s3fs (that work together to mount an S3 bucket as if it were a local disk) that depend on it. That was my motivation to restore these commands and add stubs. Do we want to remove s3 and s3fs as well?
osterman
previously approved these changes
Apr 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
what
arm64support:amd4versions of Geodesicwhy
arm64support from both versions. However, those tools are used by scripts and commands we continue to include, and we do not know how important those are to the Geodesic community. This way, they will continue to work as before foramd64versions and will generate meaningful error messages (instead of generic "command not found" errors) in thearm64version.