feat: amplify custom headers configuration #46
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/terratest |
|
@oycyc Thank you for this contribution! The tests are currently failing for an unrelated reason that we are working to resolve. Thank you for opening this PR and know that we are actively working to get it merged |
ty for the quick response! |
|
Ah I'd say just remove Terratest and use vanilla Terraform framework tests 😆 but that'll be a huge effort |
|
/terratest |
goruha
approved these changes
Jan 21, 2025
|
These changes were released in v1.1.1. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
what
Allow setting custom headers in Amplify
https://registry.terraform.io/providers/hashicorp/aws/latest/docs/resources/amplify_app#custom-headers
From Terraform docs:
why
As said in the AWS Amplify docs:
"Custom HTTP headers enable you to specify headers for every HTTP response. Response headers can be used for debugging, security, and informational purposes. You can specify headers in the Amplify console, or by downloading and editing an app's customHttp.yml file and saving it in the project's root directory."
https://docs.aws.amazon.com/amplify/latest/userguide/custom-headers.html
references
https://registry.terraform.io/providers/hashicorp/aws/latest/docs/resources/amplify_app#custom-headers