Allow custom broker name

[joshuabalduff]

what

Allow a user to set broker_name to a custom name.

why

Flexibility

references

[joshuabalduff]

@dotCipher I ran make readme but seems it removed some things, not sure if that is intended or not.

[aknysh]

thanks, please see a few comments

[aknysh]

@joshuabalduff thank you for all the changes, please remove the file .terraform.lock.hcl - we don't commit TF state lock files

[aknysh]

@joshuabalduff sorry to bother you again, the PR looks good now, please run the following commands and commit the changes:

make init
make github/init
make readme

[joshuabalduff]

No, you are totally fine. It's been a long weekend with code changes and trying to keep up. Thanks for the help. 😄

[aknysh]

/terratest

[aknysh]

@joshuabalduff
because of these errors https://github.com/cloudposse/actions/actions/runs/7091589923/job/19301058052,
I have to ask you to update the module versions in the example https://github.com/cloudposse/terraform-aws-eks-cluster/blob/main/examples/complete/main.tf

In particular:

module "vpc" - please use the version AND the input names as defined here https://github.com/cloudposse/terraform-aws-eks-cluster/blob/main/examples/complete/main.tf#L30

module "subnets" - please use the version AND the input names as defined here https://github.com/cloudposse/terraform-aws-eks-cluster/blob/main/examples/complete/main.tf#L40

thanks

[hans-d]

@joshuabalduff Hi, can you update the pr so that it passes the tests? otherwise, it is likely to be closed due to staleness.

[mergify]

Thanks @joshuabalduff for creating this pull request!

A maintainer will review your changes shortly. Please don't be discouraged if it takes a while.

While you wait, make sure to review our contributor guidelines.

Tip

Need help or want to ask for a PR review to be expedited?

Join us on Slack in the #pr-reviews channel.

[mergify]

Important

Cloud Posse Engineering Team Review Required

This pull request modifies files that require Cloud Posse's review. Please be patient, and a core maintainer will review your changes.

To expedite this process, reach out to us on Slack in the #pr-reviews channel.

[mergify]

This pull request now has conflicts. Could you fix it @joshuabalduff? 🙏

[mergify]

This PR has been closed due to inactivity and merge conflicts.
Please resolve the conflicts and reopen if necessary.