fix: Shared Images Cannot Access LastLaunched (#759)

cloudquery · Apr 22, 2022 · 5edc917 · 5edc917
1 parent 9c67026
commit 5edc917
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 0 deletions.
diff --git a/resources/services/ec2/images.go b/resources/services/ec2/images.go
@@ -325,6 +325,9 @@ func resolveEc2ImageLastLaunchedTime(ctx context.Context, meta schema.ClientMeta
 	cl := meta.(*client.Client)
 	image := resource.Item.(types.Image)
 	svc := cl.Services().EC2
+	if *image.OwnerId != cl.AccountID {
+		return nil
+	}
 	opts := ec2.DescribeImageAttributeInput{
 		Attribute: types.ImageAttributeNameLastLaunchedTime,
 		ImageId:   image.ImageId,

diff --git a/resources/services/ec2/images_mock_test.go b/resources/services/ec2/images_mock_test.go
@@ -3,6 +3,7 @@ package ec2
 import (
 	"testing"
 
+	"github.com/aws/aws-sdk-go-v2/aws"
 	"github.com/aws/aws-sdk-go-v2/service/ec2"
 	"github.com/aws/aws-sdk-go-v2/service/ec2/types"
 	"github.com/cloudquery/cq-provider-aws/client"
@@ -22,6 +23,8 @@ func buildEc2ImagesMock(t *testing.T, ctrl *gomock.Controller) client.Services {
 		t.Fatal(err)
 	}
 
+	g.OwnerId = aws.String("testAccount")
+
 	m.EXPECT().DescribeImages(gomock.Any(), gomock.Any(), gomock.Any()).Return(
 		&ec2.DescribeImagesOutput{
 			Images: []types.Image{g},