Skip to content

Commit

Permalink
fix: cleanup breadcrumbs some more
Browse files Browse the repository at this point in the history
  • Loading branch information
corwintines committed Jan 10, 2022
1 parent e76e615 commit dea49b0
Show file tree
Hide file tree
Showing 4 changed files with 4 additions and 16 deletions.
6 changes: 1 addition & 5 deletions vue-app/src/App.vue
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@
'mr-cart-closed': !isCartToggledOpen && isSideCartShown,
}"
>
<breadcrumbs v-if="showBreadCrumb" :path="path" />
<breadcrumbs v-if="showBreadCrumb" />
<router-view :key="$route.path" />
</div>
<div
Expand Down Expand Up @@ -139,10 +139,6 @@ export default class App extends Vue {
return this.$route.name !== 'landing'
}
get path(): string {
return this.$route.path
}
get isSidebarShown(): boolean {
const excludedRoutes = [
'landing',
Expand Down
2 changes: 1 addition & 1 deletion vue-app/src/components/Breadcrumbs.vue
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ export default class Breadcrumbs extends Vue {
@Prop() path!: string
get links(): Array<{ link: string; url: string }> {
const url = this.path
const url = this.$route.path
const links = url
.split('/')
Expand Down
6 changes: 1 addition & 5 deletions vue-app/src/views/JoinLanding.vue
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
<round-status-banner />

<div class="breadcrumbs">
<breadcrumbs :path="path" />
<breadcrumbs />
</div>
<div class="content" v-if="loading">
<h1>Fetching round data...</h1>
Expand Down Expand Up @@ -168,10 +168,6 @@ export default class JoinLanding extends Vue {
return [{ link: 'join', url: '/join' }]
}
get path(): string {
return this.$route.path
}
async created() {
this.currentRound = await getCurrentRound()
this.loading = false
Expand Down
6 changes: 1 addition & 5 deletions vue-app/src/views/VerifyLanding.vue
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
</div>
</div>
<div class="content">
<breadcrumbs :path="path" />
<breadcrumbs />
<div class="flex-title">
<h1>Prove you’re only using one account</h1>
</div>
Expand Down Expand Up @@ -143,10 +143,6 @@ export default class VerifyLanding extends Vue {
return this.$store.getters.hasContributionPhaseEnded
}
get path(): string {
return this.$route.path
}
formatDuration(value: number): string {
return humanizeDuration(value * 1000, { largest: 1 })
}
Expand Down

0 comments on commit dea49b0

Please sign in to comment.