implement option in FitterAlgoBase to toggle between nll backends #1028
+10
−0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements an option to forward the switch to toggle nll backends that @guitargeek implemented some time ago to the relevant peace of code. This should work for the MultiDimFit and the FitDiagnostics methods since they internally call the FitterAlgoBase. Other methods can follow as we move along.
This should make it easier to identify breaking points that custom combine classes introduce with pure RooFit code, and would be an important step for the implementation of automatic differentiation in combine.