Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unnecessary dummy object definitions from CondFormats/L1TObjects/src/classes.h #47181

Merged
merged 1 commit into from
Jan 30, 2025

Conversation

makortel
Copy link
Contributor

@makortel makortel commented Jan 24, 2025

PR description:

These have been unnecessary since many years. Noticed in #47177.

Resolves cms-sw/framework-team#1186

PR validation:

None

@cmsbuild
Copy link
Contributor

cmsbuild commented Jan 24, 2025

cms-bot internal usage

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @makortel for master.

It involves the following packages:

  • CondFormats/L1TObjects (db, alca, l1)

@aloeliger, @atpathak, @cmsbuild, @consuegs, @epalencia, @francescobrivio, @perrotta can you please review it and eventually sign? Thanks.
@JanChyczynski, @PonIlya, @missirol, @mmusich, @rsreds, @seemasharmafnal, @tocheng, @yuanchao this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@makortel
Copy link
Contributor Author

@cmsbuild, please test

@cmsbuild
Copy link
Contributor

+1

Size: This PR adds an extra 24KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4ed7a7/43942/summary.html
COMMIT: 30f2eab
CMSSW: CMSSW_15_0_X_2025-01-24-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/47181/43942/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

@perrotta
Copy link
Contributor

+1

@makortel
Copy link
Contributor Author

@cms-sw/l1-l2 Could you review and sign, please? Thanks!

@aloeliger
Copy link
Contributor

+l1

@makortel
Copy link
Contributor Author

ping bot

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @mandrenguyen, @rappoccio, @antoniovilela, @sextonkennedy (and backports should be raised in the release meeting by the corresponding L2)

@mandrenguyen
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit a523fee into cms-sw:master Jan 30, 2025
11 checks passed
@makortel makortel deleted the patch-7 branch January 30, 2025 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove unnecessary dummy object definitions from CondFormats/L1TObjects/src/classes.h
5 participants