Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NGT] Extend edmEventSize to measure leaf sizes #47248

Merged
merged 4 commits into from
Feb 7, 2025

Conversation

rsreds
Copy link
Contributor

@rsreds rsreds commented Feb 3, 2025

PR description:

This PR extends the functionality of PerfTools/EdmEvent by introducing the ability to measure individual leaf sizes in addition to branch sizes within ROOT trees.
This allows to evaluate the disk usage of single data members of the objects in a root file.
It adds an option to compute the size of each leaf in a branch (--get-leaves-size, -L).
It calculates the overhead of a branch’s size compared to the sum of its leaf sizes to obtain the same total size with both modes.
It adds an option to select the ouput format (--output-format, -f) (text or json, defaults to text).
The JSON file is formatted to work with circles.

These changes do not affect existing workflows unless explicitly enabled via the new options.

piechart (2)
An example of the data grouped by the object type of the leaves

PR validation:

Local manual verification confirm that the original branch size measurement functionality remains unchanged; the new leaf size measurement mode correctly computes sizes and overhead and JSON output is correctly formatted.
The modified tool was tested with various EDM files to ensure expected behaviour.

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

This PR is not a backport.

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 3, 2025

cms-bot internal usage

@rsreds rsreds changed the title Feature edm member size Extend edmEventSize to measure leaf sizes Feb 3, 2025
@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 3, 2025

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-47248/43531

Code check has found code style and quality issues which could be resolved by applying following patch(s)

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 3, 2025

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-47248/43532

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 3, 2025

A new Pull Request was created by @rsreds for master.

It involves the following packages:

  • PerfTools/EdmEvent (core)

@Dr15Jones, @cmsbuild, @makortel, @smuzaffar can you please review it and eventually sign? Thanks.
@felicepantaleo, @makortel this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 4, 2025

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-47248/43550

  • Found files with invalid states:
    • PerfTools/EdmEvent/bin/edmMemberSize.cpp:

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 4, 2025

Pull request #47248 was updated. @Dr15Jones, @cmsbuild, @makortel, @smuzaffar can you please check and sign again.

@fwyzard
Copy link
Contributor

fwyzard commented Feb 4, 2025

please test

@fwyzard
Copy link
Contributor

fwyzard commented Feb 4, 2025

allow @rsreds test rights

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 5, 2025

Pull request #47248 was updated. @Dr15Jones, @cmsbuild, @makortel, @smuzaffar can you please check and sign again.

@makortel
Copy link
Contributor

makortel commented Feb 5, 2025

@cmsbuild, please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 5, 2025

+1

Size: This PR adds an extra 24KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-3ecc7e/44216/summary.html
COMMIT: 8f8f7c9
CMSSW: CMSSW_15_0_X_2025-02-04-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/47248/44216/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

@rsreds rsreds changed the title Extend edmEventSize to measure leaf sizes [NGT] Extend edmEventSize to measure leaf sizes Feb 6, 2025
@makortel
Copy link
Contributor

makortel commented Feb 6, 2025

Comparison differences are related to #39803 and #47071

@makortel
Copy link
Contributor

makortel commented Feb 6, 2025

+core

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 6, 2025

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @mandrenguyen, @sextonkennedy, @rappoccio, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2)

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 7, 2025

Milestone for this pull request has been moved to CMSSW_15_1_X. Please open a backport if it should also go in to CMSSW_15_0_X.

@cmsbuild cmsbuild modified the milestones: CMSSW_15_0_X, CMSSW_15_1_X Feb 7, 2025
@mandrenguyen
Copy link
Contributor

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants