-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[NGT] Extend edmEventSize to measure leaf sizes #47248
Conversation
cms-bot internal usage |
-code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-47248/43531
Code check has found code style and quality issues which could be resolved by applying following patch(s)
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-47248/43532
|
A new Pull Request was created by @rsreds for master. It involves the following packages:
@Dr15Jones, @cmsbuild, @makortel, @smuzaffar can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
d63736c
to
e9e159e
Compare
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-47248/43550 |
Pull request #47248 was updated. @Dr15Jones, @cmsbuild, @makortel, @smuzaffar can you please check and sign again. |
please test |
allow @rsreds test rights |
Pull request #47248 was updated. @Dr15Jones, @cmsbuild, @makortel, @smuzaffar can you please check and sign again. |
@cmsbuild, please test |
+1 Size: This PR adds an extra 24KB to repository Comparison SummarySummary:
|
+core |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @mandrenguyen, @sextonkennedy, @rappoccio, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2) |
Milestone for this pull request has been moved to CMSSW_15_1_X. Please open a backport if it should also go in to CMSSW_15_0_X. |
+1 |
PR description:
This PR extends the functionality of
PerfTools/EdmEvent
by introducing the ability to measure individual leaf sizes in addition to branch sizes within ROOT trees.This allows to evaluate the disk usage of single data members of the objects in a root file.
It adds an option to compute the size of each leaf in a branch (
--get-leaves-size
,-L
).It calculates the overhead of a branch’s size compared to the sum of its leaf sizes to obtain the same total size with both modes.
It adds an option to select the ouput format (
--output-format
,-f
) (text or json, defaults to text).The JSON file is formatted to work with circles.
These changes do not affect existing workflows unless explicitly enabled via the new options.
An example of the data grouped by the object type of the leaves
PR validation:
Local manual verification confirm that the original branch size measurement functionality remains unchanged; the new leaf size measurement mode correctly computes sizes and overhead and JSON output is correctly formatted.
The modified tool was tested with various EDM files to ensure expected behaviour.
If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:
This PR is not a backport.