[GCC14] template-id not allowed for constructor in C++20

[iarspider]

PR description:

GCC14 complains that template-id is not allowed for constructor:

    In file included from src/DataFormats/TrackSoA/interface/alpaka/TracksSoACollection.h:9,
                     from src/RecoVertex/PixelVertexFinding/plugins/alpaka/PixelVertexProducerAlpaka.cc:17:
    src/DataFormats/TrackSoA/interface/TracksDevice.h:31:46: warning: template-id not allowed for constructor in C++20 [-Wtemplate-id-cdtor]
       31 |   explicit TracksDevice<TrackerTraits, TDev>(TQueue& queue)
          |                                              ^~~~~~
    src/DataFormats/TrackSoA/interface/TracksDevice.h:31:46: note: remove the '< >'
    In file included from src/DataFormats/TrackSoA/interface/alpaka/TracksSoACollection.h:10:
    src/DataFormats/TrackSoA/interface/TracksHost.h:32:38: warning: template-id not allowed for constructor in C++20 [-Wtemplate-id-cdtor]
       32 |   explicit TracksHost<TrackerTraits>(TQueue& queue)
          |                                      ^~~~~~
    src/DataFormats/TrackSoA/interface/TracksHost.h:32:38: note: remove the '< >'

This PR fixes this warning.

PR validation:

Bot tests.

[iarspider]

please test

[cmsbuild]

cms-bot internal usage

[cmsbuild]

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-47265/43565

• There are other open Pull requests which might conflict with changes you have proposed:
  • File DataFormats/TrackSoA/interface/TracksHost.h modified in PR(s): CA Extension to strips #47090

Code check has found code style and quality issues which could be resolved by applying following patch(s)

• code-format:
  https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-47265/43565/code-format.patch
  e.g. curl -k https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-47265/43565/code-format.patch | patch -p1
  You can also run scram build code-format to apply code format directly

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-47265/43566

• There are other open Pull requests which might conflict with changes you have proposed:
  • File DataFormats/TrackSoA/interface/TracksHost.h modified in PR(s): CA Extension to strips #47090

[cmsbuild]

A new Pull Request was created by @iarspider for master.

It involves the following packages:

• DataFormats/TrackSoA (reconstruction, heterogeneous)

@cmsbuild, @fwyzard, @jfernan2, @makortel, @mandrenguyen can you please review it and eventually sign? Thanks.
@VinInn, @VourMa, @gpetruc, @missirol, @mmusich, @mtosi, @rovere this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

[iarspider]

please test

[fwyzard]

+heterogeneous

[iarspider]

please test for el8_amd64_gcc14

[cmsbuild]

-1

Failed Tests: Build
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-f990e7/44208/summary.html
COMMIT: a85a3f6
CMSSW: CMSSW_15_0_X_2025-02-01-1100/el8_amd64_gcc14
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/47265/44208/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

• @bsunanda Phase2-gex186C Modify all Run4 scenarios to include the modified RPC geometry #47160
• @aloeliger Synchronize L1T L1TReEmulFromRAW and Repack_Full configurations #46198
• @AlexDeMoor Introduce Unified Particle Transformer v2 #47173
• @iarspider Remove unused variable in TestAssociator.cc #47199
• @nurfikri89 [JME,Nano] Refactor constituents table, add GloParT WvsQCD score #47206
• @24LopezR Process modifier for displaced SUSY simulation fix #47197
• @hqucms Add matrix tests for reMINI + NANOv15 #47231
• @mmusich add more limited matrix options, separately for Run1&2, Run3, Phase2 and HeavyIons #47205
• @hqucms [NANO] Fix PS weight parsing #47253
• @mmusich add fillDescriptions to several plugins used at HLT (5/N) #47224
• @bsunanda Run3-gex187X Add a test script to test all scenarios of 2021 #47243
• @fwyzard Add missing #include in CondFormats/Common #47240
• @makortel Remove default constructor from Alpaka EDProducer base classes #47227
• @SegmentLinking Dynamic Memory Allocation for LST Objects #47232
• @makortel Copy also chi2 for HCAL RecHits in HCALRecHitSoAProducer #47256
• @makortel Migrate Alpaka EDProducers to pass the edm::ParameterSet to base class constructor #47216

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-f990e7/44208/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-f990e7/44208/git-merge-result

Build

I found compilation error when building:

Copying tmp/el8_amd64_gcc14/src/RecoLocalCalo/EcalRecProducers/plugins/RecoLocalCaloEcalRecProducersPluginsPortableROCmAsync/libRecoLocalCaloEcalRecProducersPluginsPortableROCmAsync_rocm.a to productstore area:
Copying tmp/el8_amd64_gcc14/src/RecoLocalCalo/HGCalRecAlgos/plugins/RecoLocalCaloHGCalRecAlgosPluginsPortableROCmAsync/libRecoLocalCaloHGCalRecAlgosPluginsPortableROCmAsync_rocm.a to productstore area:
Copying tmp/el8_amd64_gcc14/src/RecoLocalCalo/HGCalRecProducers/plugins/RecoLocalCaloHGCalRecProducersPluginsPortableROCmAsync/libRecoLocalCaloHGCalRecProducersPluginsPortableROCmAsync_rocm.a to productstore area:
cp: cannot stat 'tmp/el8_amd64_gcc14/src/RecoLocalCalo/HGCalRecProducers/plugins/RecoLocalCaloHGCalRecProducersPluginsPortableROCmAsync/libRecoLocalCaloHGCalRecProducersPluginsPortableROCmAsync_rocm.a': No such file or directory
>> Deleted: tmp/el8_amd64_gcc14/src/RecoLocalCalo/HGCalRecProducers/plugins/RecoLocalCaloHGCalRecProducersPluginsPortableROCmAsync/libRecoLocalCaloHGCalRecProducersPluginsPortableROCmAsync_rocm.a
gmake: *** [config/SCRAM/GMake/Makefile.rules:1886: tmp/el8_amd64_gcc14/src/RecoLocalCalo/HGCalRecProducers/plugins/RecoLocalCaloHGCalRecProducersPluginsPortableROCmAsync/libRecoLocalCaloHGCalRecProducersPluginsPortableROCmAsync_rocm.a] Error 1
Copying tmp/el8_amd64_gcc14/src/RecoLocalCalo/HcalRecProducers/plugins/RecoLocalCaloHcalRecProducersPluginsPortableROCmAsync/libRecoLocalCaloHcalRecProducersPluginsPortableROCmAsync_rocm.a to productstore area:
Copying tmp/el8_amd64_gcc14/src/RecoLocalTracker/SiPixelClusterizer/plugins/RecoLocalTrackerSiPixelClusterizerPluginsPortableROCmAsync/libRecoLocalTrackerSiPixelClusterizerPluginsPortableROCmAsync_rocm.a to productstore area:
Copying tmp/el8_amd64_gcc14/src/RecoLocalTracker/SiPixelRecHits/plugins/RecoLocalTrackerSiPixelRecHitsPluginsPortableROCmAsync/libRecoLocalTrackerSiPixelRecHitsPluginsPortableROCmAsync_rocm.a to productstore area:
cp: cannot stat 'tmp/el8_amd64_gcc14/src/RecoLocalTracker/SiPixelRecHits/plugins/RecoLocalTrackerSiPixelRecHitsPluginsPortableROCmAsync/libRecoLocalTrackerSiPixelRecHitsPluginsPortableROCmAsync_rocm.a': No such file or directory
>> Deleted: tmp/el8_amd64_gcc14/src/RecoLocalTracker/SiPixelRecHits/plugins/RecoLocalTrackerSiPixelRecHitsPluginsPortableROCmAsync/libRecoLocalTrackerSiPixelRecHitsPluginsPortableROCmAsync_rocm.a


[iarspider]

Build failures for gcc14 is expected - some will be fixed by #47266.

[cmsbuild]

+1

Size: This PR adds an extra 24KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-f990e7/44204/summary.html
COMMIT: a85a3f6
CMSSW: CMSSW_15_0_X_2025-02-04-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/47265/44204/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

• @mmusich add fillDescriptions to several plugins used at HLT (5/N) #47224

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-f990e7/44204/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-f990e7/44204/git-merge-result

Comparison Summary

Summary:

• You potentially added 1 lines to the logs
• Reco comparison results: 131 differences found in the comparisons
• DQMHistoTests: Total files compared: 51
• DQMHistoTests: Total histograms compared: 4130882
• DQMHistoTests: Total failures: 2429
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 4128433
• DQMHistoTests: Total skipped: 20
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 50 files compared)
• Checked 222 log files, 194 edm output root files, 51 DQM output files
• TriggerResults: no differences found

[jfernan2]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @mandrenguyen, @antoniovilela, @sextonkennedy, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

[mandrenguyen]

+1