-
Notifications
You must be signed in to change notification settings - Fork 555
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
create observability.md #1639
create observability.md #1639
Conversation
Signed-off-by: swastiksingh22 <[email protected]>
✅ Deploy Preview for cncfglossary ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @swastiksingh22 , The content of observability has changed on the English version. It would be nice if we can update this PR with latest content
@swastiksingh22 gentle ping to implement necessary changes |
Co-authored-by: Anubhav Vardhan <[email protected]> Signed-off-by: Anuj Tiwari <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good to me!
@swastiksingh22 you need to change target branch from 'cncf: main' to 'cncf: dev-hi'. |
Looks good to me 👍 |
Signed-off-by: swastiksingh22 [email protected]
Describe your changes
I have added hindi version of observability.md. Thankyou I'll wait for your response.
Related issue number or link (ex:
resolves #issue-number
)Checklist before opening this PR (put
x
in the checkboxes)git commit -s
) is to affirm that commits comply DCO. If you are working locally, you could add an alias to yourgitconfig
by runninggit config --global alias.ci "commit -s"
.