Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

create observability.md #1639

Merged
merged 2 commits into from
Nov 26, 2023
Merged

create observability.md #1639

merged 2 commits into from
Nov 26, 2023

Conversation

swastiksingh22
Copy link
Contributor

Signed-off-by: swastiksingh22 [email protected]

Describe your changes

I have added hindi version of observability.md. Thankyou I'll wait for your response.

Related issue number or link (ex: resolves #issue-number)

Checklist before opening this PR (put x in the checkboxes)

  • This PR does not contain plagiarism
    • don’t copy other people’s work unless you are quoting and contributing it to them.
  • I have signed off on all commits
    • signing off (ex: git commit -s) is to affirm that commits comply DCO. If you are working locally, you could add an alias to your gitconfig by running git config --global alias.ci "commit -s".

Signed-off-by: swastiksingh22 <[email protected]>
@netlify
Copy link

netlify bot commented Jan 23, 2023

Deploy Preview for cncfglossary ready!

Name Link
🔨 Latest commit 82539c0
🔍 Latest deploy log https://app.netlify.com/sites/cncfglossary/deploys/65506eb00be34c00089d97ab
😎 Deploy Preview https://deploy-preview-1639--cncfglossary.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@sayantani11 sayantani11 added the lang/hi for Hindi label Jan 24, 2023
Copy link
Contributor

@anubha-v-ardhan anubha-v-ardhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @swastiksingh22 , The content of observability has changed on the English version. It would be nice if we can update this PR with latest content

content/hi/observability.md Outdated Show resolved Hide resolved
@aj11anuj
Copy link
Collaborator

aj11anuj commented Oct 6, 2023

@swastiksingh22 gentle ping to implement necessary changes

Co-authored-by: Anubhav Vardhan <[email protected]>
Signed-off-by: Anuj Tiwari <[email protected]>
Copy link
Collaborator

@aj11anuj aj11anuj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm 👍

@aj11anuj aj11anuj added the Awaiting/2nd-approval This PR needs another approval review label Nov 12, 2023
Copy link
Contributor

@justankiit justankiit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me!

@aj11anuj
Copy link
Collaborator

@swastiksingh22 you need to change target branch from 'cncf: main' to 'cncf: dev-hi'.

@aj11anuj aj11anuj changed the base branch from main to dev-hi November 17, 2023 15:50
@abhay-raj19
Copy link
Collaborator

Looks good to me 👍
Thanks @swastiksingh22 for contributing

@aj11anuj aj11anuj merged commit dc2d4c7 into cncf:dev-hi Nov 26, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting/2nd-approval This PR needs another approval review lang/hi for Hindi
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants