Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[hi] Localize self-healing.md #1642

Merged
merged 7 commits into from
Nov 17, 2023
Merged

[hi] Localize self-healing.md #1642

merged 7 commits into from
Nov 17, 2023

Conversation

ShivangShandilya
Copy link
Contributor

@ShivangShandilya ShivangShandilya commented Jan 24, 2023

Signed-off-by: Shivang Shandilya [email protected]

Describe your changes

This PR adds self-healing.md in Hindi Language

Related issue number or link (ex: resolves #issue-number)

Resolves #1593

Checklist before opening this PR (put x in the checkboxes)

  • This PR does not contain plagiarism
    • don’t copy other people’s work unless you are quoting and contributing it to them.
  • I have signed off on all commits
    • signing off (ex: git commit -s) is to affirm that commits comply DCO. If you are working locally, you could add an alias to your gitconfig by running git config --global alias.ci "commit -s".

Signed-off-by: Shivang Shandilya <[email protected]>
@netlify
Copy link

netlify bot commented Jan 24, 2023

Deploy Preview for cncfglossary ready!

Name Link
🔨 Latest commit abd5b4a
🔍 Latest deploy log https://app.netlify.com/sites/cncfglossary/deploys/65506b7ec6ce5f0008abbe8e
😎 Deploy Preview https://deploy-preview-1642--cncfglossary.netlify.app/hi/self-healing
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@sayantani11 sayantani11 added the lang/hi for Hindi label Jan 24, 2023
Signed-off-by: Shivang Shandilya <[email protected]>
@ShivangShandilya ShivangShandilya changed the title Adding self-healing.md in Hindi Adding self-healing.md and horizontal-scaling.md in Hindi Jan 24, 2023
Signed-off-by: Shivang Shandilya <[email protected]>
@ShivangShandilya ShivangShandilya changed the title Adding self-healing.md and horizontal-scaling.md in Hindi Adding self-healing.md in Hindi Feb 7, 2023
Copy link
Collaborator

@aj11anuj aj11anuj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some suggestions from my side

content/hi/self-healing.md Outdated Show resolved Hide resolved
content/hi/self-healing.md Outdated Show resolved Hide resolved
content/hi/self-healing.md Outdated Show resolved Hide resolved
content/hi/self-healing.md Outdated Show resolved Hide resolved
content/hi/self-healing.md Outdated Show resolved Hide resolved
content/hi/self-healing.md Outdated Show resolved Hide resolved
content/hi/self-healing.md Outdated Show resolved Hide resolved
Signed-off-by: Anuj Tiwari <[email protected]>
content/hi/self-healing.md Outdated Show resolved Hide resolved
Copy link
Collaborator

@aj11anuj aj11anuj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm 👍

@aj11anuj aj11anuj added the Awaiting/2nd-approval This PR needs another approval review label Nov 12, 2023
Copy link
Contributor

@justankiit justankiit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@aj11anuj
Copy link
Collaborator

@ShivangShandilya you need to change target branch from 'cncf: main' to 'cncf: dev-hi'.

Copy link
Collaborator

@bishal7679 bishal7679 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
Thank you @ShivangShandilya

@bishal7679 bishal7679 changed the base branch from main to dev-hi November 17, 2023 13:57
@bishal7679 bishal7679 changed the title Adding self-healing.md in Hindi [hi] Localize self-healing.md Nov 17, 2023
@bishal7679 bishal7679 merged commit c586b20 into cncf:dev-hi Nov 17, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting/2nd-approval This PR needs another approval review lang/hi for Hindi
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[hi] Localize self-healing.md to Hindi
5 participants