Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[hi] Localize idempotence.md to Hindi #1729

Merged
merged 4 commits into from
Nov 16, 2023
Merged

Conversation

neelshah2409
Copy link
Contributor

Signed-off-by: Neel Shah ([email protected])

Describe your changes

  • Localize idempotence.md to Hindi

Related issue number or link (ex: resolves #issue-number)

Checklist before opening this PR (put x in the checkboxes)

  • This PR does not contain plagiarism
    • don’t copy other people’s work unless you are quoting and contributing it to them.
  • I have signed off on all commits
    • signing off (ex: git commit -s) is to affirm that commits comply DCO. If you are working locally, you could add an alias to your gitconfig by running git config --global alias.ci "commit -s".

Signed-off-by: Neel Shah <[email protected]>
@netlify
Copy link

netlify bot commented Feb 15, 2023

Deploy Preview for cncfglossary ready!

Name Link
🔨 Latest commit aca2af4
🔍 Latest deploy log https://app.netlify.com/sites/cncfglossary/deploys/655328ce0cc02e00082d6f43
😎 Deploy Preview https://deploy-preview-1729--cncfglossary.netlify.app/hi/idempotence
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Collaborator

@aj11anuj aj11anuj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some suggestions from my side

content/hi/idempotence.md Outdated Show resolved Hide resolved
content/hi/idempotence.md Outdated Show resolved Hide resolved
content/hi/idempotence.md Outdated Show resolved Hide resolved
Signed-off-by: Anuj Tiwari <[email protected]>
@aj11anuj aj11anuj added the Awaiting/2nd-approval This PR needs another approval review label Nov 12, 2023
Copy link
Collaborator

@bishal7679 bishal7679 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Commit these if you find useful!

content/hi/idempotence.md Outdated Show resolved Hide resolved
content/hi/idempotence.md Outdated Show resolved Hide resolved
@bishal7679
Copy link
Collaborator

@neelshah2409 Please make one empty commit by sign-off and Please change the target branch of this PR to dev-hi, not main.

@bishal7679 bishal7679 changed the base branch from main to dev-hi November 16, 2023 18:06
Copy link
Collaborator

@bishal7679 bishal7679 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ready to merge!

@bishal7679 bishal7679 merged commit 298f014 into cncf:dev-hi Nov 16, 2023
4 of 5 checks passed
Copy link
Contributor

@justankiit justankiit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, Thanks @neelshah2409

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting/2nd-approval This PR needs another approval review lang/hi for Hindi
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[hi] Localize Idempotence to Hindi
5 participants