-
Notifications
You must be signed in to change notification settings - Fork 555
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update approvers for Hindi localization #2586
Conversation
Signed-off-by: Seokho Son <[email protected]>
Signed-off-by: Seokho Son <[email protected]>
✅ Deploy Preview for cncfglossary ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Hello
Welcome to the localization approver role! Please examine and confirm the following policies thoroughly. :) After you confirmed it, please leave a comment in this PR. |
Thanks for sharing the new updates @seokho-son. |
Thanks for sharing @seokho-son |
Thanks @seokho-son |
@seokho-son |
ref: cncf/people#312 |
Hi maintainers ! I think this PR is ready to be merged! PTAL. :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
Thanks everybody!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you all!
Describe your changes
Add a new approver for Hindi based on a requested by the localization team.
Step down approvers for Hindi based on a requested by the localization team.
Thanks to @anubha-v-ardhan @sayantani11 for their valuable contributions so far.
Welcome new localization approver candidates.
We are going to temporarily increase the maximum number of approvers (so far, it is upto 5 but extend to 6 approvers) and later adjust based on future activities. It is an exceptional case aimed at bolstering the team and only focused on their willingness.
Related issue number or link (ex:
resolves #issue-number
)Checklist before opening this PR (put
x
in the checkboxes)git commit -s
) is to affirm that commits comply DCO. If you are working locally, you could add an alias to yourgitconfig
by runninggit config --global alias.ci "commit -s"
.