Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update approvers for Hindi localization #2586

Merged
merged 2 commits into from
Nov 8, 2023

Conversation

seokho-son
Copy link
Collaborator

Describe your changes

Add a new approver for Hindi based on a requested by the localization team.

Step down approvers for Hindi based on a requested by the localization team.

Thanks to @anubha-v-ardhan @sayantani11 for their valuable contributions so far.
Welcome new localization approver candidates.

  • Please note that
    We are going to temporarily increase the maximum number of approvers (so far, it is upto 5 but extend to 6 approvers) and later adjust based on future activities. It is an exceptional case aimed at bolstering the team and only focused on their willingness.

Related issue number or link (ex: resolves #issue-number)

Checklist before opening this PR (put x in the checkboxes)

  • This PR does not contain plagiarism
    • don’t copy other people’s work unless you are quoting and contributing it to them.
  • I have signed off on all commits
    • signing off (ex: git commit -s) is to affirm that commits comply DCO. If you are working locally, you could add an alias to your gitconfig by running git config --global alias.ci "commit -s".

Copy link

netlify bot commented Nov 6, 2023

Deploy Preview for cncfglossary ready!

Name Link
🔨 Latest commit af5e7db
🔍 Latest deploy log https://app.netlify.com/sites/cncfglossary/deploys/65490d6a95db2400070451b2
😎 Deploy Preview https://deploy-preview-2586--cncfglossary.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@seokho-son
Copy link
Collaborator Author

seokho-son commented Nov 6, 2023

Hello

Welcome to the localization approver role!

Please examine and confirm the following policies thoroughly. :)
Policies for localization approvers (to be confirmed by candidates) #723

After you confirmed it, please leave a comment in this PR.

@abhay-raj19
Copy link
Collaborator

Thanks for sharing the new updates @seokho-son.
Read the policy thoroughly and got a good understanding of Approving the changes.

@bishal7679
Copy link
Collaborator

Thanks for sharing @seokho-son
Went through the policies and understood this regulation
will comply with the Policies 👍

@justankiit
Copy link
Contributor

Thanks @seokho-son
Went through the policies and understood this regulations in this PR

@seokho-son seokho-son added the maintainers Use this label if PR requires maintainers to take action label Nov 6, 2023
@aj11anuj
Copy link
Collaborator

aj11anuj commented Nov 7, 2023

@seokho-son
I understood and will abide by those policies 👍

@seokho-son
Copy link
Collaborator Author

ref: cncf/people#312

@seokho-son
Copy link
Collaborator Author

Hi maintainers !
@iamNoah1 @jihoon-seo @nate-double-u

I think this PR is ready to be merged! PTAL. :)

Copy link
Member

@nate-double-u nate-double-u left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
Thanks everybody!

Copy link
Collaborator

@jihoon-seo jihoon-seo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you all!

@jihoon-seo jihoon-seo merged commit 00d3ca8 into cncf:main Nov 8, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintainers Use this label if PR requires maintainers to take action
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants