Add mboukhalfa, seifrajhi, adowair as codeowners for AR #3141
Conversation
adowair
requested review from
caniszczyk,
seokho-son,
iamNoah1,
jihoon-seo and
nate-double-u
as code owners
✅ Deploy Preview for cncfglossary ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
This commit will add mboukhalfa, seifrajhi, and adowair as codeowners for the Arabic CNCF glossary. Signed-off-by: Ali Dowair <[email protected]>
adowair
changed the title
|
@arezk84 Did you notice the error message on the Changed Files tab ? |
|
@mboukhalfa |
jihoon-seo
added
lang/ar
|
From the GitHub Docs, it looks we we need to have write access to the repo first:
...and this is defined in Lines 112 to 123 in 5c1f681 |
This commit will also give the proposed codeowners push permissons to the repository, as this is a requirement for code ownershp to work properly. Signed-off-by: Ali Dowair <[email protected]>
|
Hei @adowair, all new approvers first need to read, understand and agree to the following discussion by commenting it: #723 After that I need to open an PR in https://github.com/cncf/people to add the new approvers :) cc @mboukhalfa @seifrajhi @arezk84 @TarekMSayed |
|
/hold @mboukhalfa and @seifrajhi also need to agree :) |
|
Wait, please do not proceed with this yet. |
|
@mboukhalfa friendly reminder to comment: #723 |
done sorry for late reply |
|
@mboukhalfa @seifrajhi @adowair finally I can merge this, welcome as approvers :) |
Describe your changes
This commit will add mboukhalfa, seifrajhi, and adowair as codeowners for the Arabic CNCF glossary.
Related issue number or link (ex:
resolves #issue-number)https://cloud-native.slack.com/archives/C02UFT8V256/p1714310155244299
Checklist before opening this PR (put
xin the checkboxes)git commit -s) is to affirm that commits comply DCO. If you are working locally, you could add an alias to yourgitconfigby runninggit config --global alias.ci "commit -s".